Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set deallocated pointers to NULL whenever they are not reassigned immediately after #842

Merged
merged 1 commit into from
May 9, 2024
Merged

Set deallocated pointers to NULL whenever they are not reassigned immediately after #842

merged 1 commit into from
May 9, 2024

Conversation

maebex
Copy link
Contributor

@maebex maebex commented Mar 30, 2024 •
edited
Loading

Fixes #833

@Alanscut
Copy link
Collaborator

Hi @maebex
Thanks for your contribution.
Maybe we can have some tests along with your fix?

@Alanscut Alanscut merged commit 1ac905d into DaveGamble:develop May 9, 2024
@Alanscut
Copy link
Collaborator

Alanscut commented May 9, 2024

Awww
I didn't notice this PR was pushing to branch develop.

Alanscut added a commit to Alanscut/cJSON that referenced this pull request May 9, 2024
@Alanscut
feat: add tests for DaveGamble#842
5b8ec9e 
Add some tests for setting NULL to deallocated pointers
releated to DaveGamble#842 and DaveGamble#833
@Alanscut Alanscut mentioned this pull request May 9, 2024
Merged
Alanscut added a commit to Alanscut/cJSON that referenced this pull request May 9, 2024
@Alanscut
feat: add tests for DaveGamble#842
7280422 
Add some tests for setting NULL to deallocated pointers
releated to DaveGamble#842 and DaveGamble#833
@Alanscut
Copy link
Collaborator

Alanscut commented May 9, 2024

Hi @maebex

I cherry-picked your commit to branch master and added some tests.

Please take a look at #855

Alanscut added a commit that referenced this pull request May 13, 2024
@Alanscut
feat: add tests for #842
5b502cd 
Add some tests for setting NULL to deallocated pointers
releated to #842 and #833
Alanscut added a commit to Alanscut/cJSON that referenced this pull request Jun 19, 2024
@Alanscut
Revert "feat: add tests for DaveGamble#842" to fix test failures
a6206ae 
This reverts commit 5b502cd.

Related to DaveGamble#860
Alanscut added a commit that referenced this pull request Jun 19, 2024
@Alanscut
Revert "feat: add tests for #842" to fix test failures
424ce4c 
This reverts commit 5b502cd.

Related to #860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maebex @Alanscut