-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ArrowField derive macro #88
Conversation
…lize derives for more composability.
Thanks for the change, please let me know if you need help fixing any of the CI. |
Looks like CI hasn't run in a few months. I fixed everything here I think, which should also fix #89 if we land that after. |
Thanks for fixing. main hasn't had changes since November, which is why CI hasn't run. We shifted development to a feature branch which requires rust 1.65 features. I'll rebase those changes on top of yours. |
Looks like tests still failing, please let me know if you need help. |
I guess we should bump the version as well since this is breaking :) |
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 95.31% 98.25% +2.94%
==========================================
Files 8 8
Lines 1450 1490 +40
==========================================
+ Hits 1382 1464 +82
+ Misses 68 26 -42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR splits the ArrowField derive macro into separate macros for each derived trait.
Why: the previous undocumented container attributes to control which traits get implemented is not flexible enough. This way users have complete control over which trait gets generated.