-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficient deserialization for Buffer<u8> #103
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 94.63% 94.58% -0.05%
==========================================
Files 8 8
Lines 1565 1588 +23
==========================================
+ Hits 1481 1502 +21
- Misses 84 86 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1f2a647
to
b4299e6
Compare
It could be nice to cover |
Interestingly these benches show this work might not have actually been all that necessary.
|
Thanks for the change! |
This implements ArrowDeserialize for Buffer as part of #101
There are a few hoops to jump through because the
BinaryArray<i32>
normally exposes an iterator which is &[u8] slices, whereas we want to expose a Buffer primitive directly to take advantage of the Arc behavior of arrow Buffers.