Update proto definition and dependencies. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update prost dependency to 0.10.x. Update tonic dependency to 0.7.x. Update crate version to 0.4.0 to match crate.io.
Contributor
|
Thanks a lot, makes a lot of sense! Will bump this one and bump it in arrow2 so that we have everything aligned 👍 |
jorgecarleitao
pushed a commit
that referenced
this pull request
May 26, 2022
Update prost dependency to 0.10.x. Update tonic dependency to 0.7.x. Update crate version to 0.4.0 to match crate.io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update to latest dependencies. Similar to PR #2.
Details
In order to be able to use
arrow2andarrow-formatwith the latesttonicandprostcrates, I had to patch the repository as following (the old files generated withprostare not compatible with these new versions).prostdependency to 0.10.x.tonicdependency to 0.7.x.crateversion to 0.4.0 to match crate.io version andarrow2dependency constraints.cargo fmt --allRegarding the first point, I used the latest proto definition file from
arrowgithub. There are no fundamental changes, only clarifications around comments.I expect that the crate version should be bumped to 0.5.0 before releasing this crate (i.e. not part of this PR).