Do not instrument every JVM by default #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuelPalenzuelaDD
approved these changes
Nov 6, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Java instrumentation logic: now by default only Maven, Gradle, SBT, and Ant builds will be instrumented.
Before the update the tracer was injected into every JVM process.
Motivation
Injecting the tracer in every JVM process is too intrusive and causes issues.
Some processes fail to exit when running with the tracer injected: e.g. compilers or code generation tools.
It is difficult to identify all such processes and to fix the issue for all of them.
Therefore the logic is updated to err on the side of caution and only instrument the commonly used build systems.
For edge cases an "escape hatch" is left: by setting the
DD_INSTRUMENTATION_BUILD_SYSTEM_JAVA=allit is possible to revert to the old behaviour of instrumenting everything.Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes