Skip to content

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Dec 4, 2025

Motivation

Apparently .venv is a thing.

Changes

Workflow

  1. ⚠️ Create your PR as draf
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by t
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bric3 bric3 requested a review from a team as a code owner December 4, 2025 16:39
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

CODEOWNERS have been resolved as:

.gitignore                                                              @DataDog/system-tests-core

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosh ! On your local computer ?

@bric3
Copy link
Contributor Author

bric3 commented Dec 4, 2025

Yep, unsure how it got created.

@bric3 bric3 merged commit 0009703 into main Dec 5, 2025
387 checks passed
@bric3 bric3 deleted the bdu/ignore-dot-venv branch December 5, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants