Skip to content

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Dec 4, 2025

Motivation

Makes test agent report version 7.65.0, fix for

Uses

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bric3 bric3 requested review from a team as code owners December 4, 2025 16:31
@bric3 bric3 requested review from mcculls and removed request for a team December 4, 2025 16:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

CODEOWNERS have been resolved as:

tests/parametric/test_library_tracestats.py                             @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
tests/parametric/test_span_sampling.py                                  @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@bric3 bric3 force-pushed the bdu/use-test-agent-version-765 branch from 21f8fa5 to 3526fd5 Compare December 4, 2025 17:05
@bric3 bric3 requested a review from cbeauchesne December 5, 2025 10:48
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be interesting, as a follow up, to add a specific test for the contrary (e.g. not activating CSS for previous version of the agent)

@bric3 bric3 dismissed cbeauchesne’s stale review December 5, 2025 14:43

Need to progress on this I'll fix back the tests if something need to be fixed.

@bric3 bric3 merged commit c0961f7 into main Dec 5, 2025
394 checks passed
@bric3 bric3 deleted the bdu/use-test-agent-version-765 branch December 5, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants