Skip to content

Ruby: enable blocking response id test for custom redirect#5739

Merged
y9v merged 1 commit intomainfrom
ruby-enable-security-response-id-test-for-redirects
Nov 19, 2025
Merged

Ruby: enable blocking response id test for custom redirect#5739
y9v merged 1 commit intomainfrom
ruby-enable-security-response-id-test-for-redirects

Conversation

@y9v
Copy link
Member

@y9v y9v commented Nov 19, 2025

Motivation

Security response ID was added for AppSec custom redirect responses recently:
DataDog/dd-trace-rb#5060

Changes

This PR enables the remaining Security Response ID tests for Ruby.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Nov 19, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby

@y9v y9v marked this pull request as ready for review November 19, 2025 10:34
@y9v y9v requested review from a team as code owners November 19, 2025 10:34
@y9v y9v merged commit d6008cd into main Nov 19, 2025
66 checks passed
@y9v y9v deleted the ruby-enable-security-response-id-test-for-redirects branch November 19, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants