Skip to content

Conversation

@mobuchowski
Copy link
Contributor

Motivation

Fixing system tests for DataDog/dd-trace-java#8541
https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness
Following up from https://github.com/DataDog/dd-go/pull/177088

Changes

Running ./utils/telemetry/intake/update.sh as suggested by runbook ⬆️ resulted in changes - mostly removals - for all the rules files...

	modified:   utils/telemetry/intake/static/config_norm_rules.json
	modified:   utils/telemetry/intake/static/config_prefix_block_list.json
	modified:   utils/telemetry/intake/static/dotnet_config_rules.json
	modified:   utils/telemetry/intake/static/go_config_rules.json
	modified:   utils/telemetry/intake/static/jvm_config_rules.json
	modified:   utils/telemetry/intake/static/nodejs_config_rules.json
	modified:   utils/telemetry/intake/static/php_config_rules.json
	modified:   utils/telemetry/intake/static/python_config_rules.json
	modified:   utils/telemetry/intake/static/ruby_config_rules.json

I just left the only relevant change there to my original change.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mobuchowski mobuchowski force-pushed the mobuchowski/update-config-data-jobs branch from 81ec7d9 to 499c963 Compare April 1, 2025 08:08
@mobuchowski mobuchowski marked this pull request as ready for review April 1, 2025 11:00
@mobuchowski mobuchowski requested a review from a team as a code owner April 1, 2025 11:00
@mobuchowski mobuchowski requested review from nayeem-kamal and removed request for a team April 1, 2025 11:00
@mobuchowski
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 1, 2025

View all feedbacks in Devflow UI.
2025-04-01 12:15:49 UTC ℹ️ Start processing command /merge


2025-04-01 12:15:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-04-01 12:32:31 UTCMergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy

@cbeauchesne
Copy link
Collaborator

@mobuchowski , we're not using devflow, you can hit the squash button (once the CI is finished)

@mobuchowski mobuchowski merged commit cad0d5f into main Apr 1, 2025
1232 of 1296 checks passed
@mobuchowski mobuchowski deleted the mobuchowski/update-config-data-jobs branch April 1, 2025 13:04
mtoffl01 pushed a commit that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants