Skip to content

Add force_skip option#3587

Merged
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/force-skip
Nov 28, 2024
Merged

Add force_skip option#3587
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/force-skip

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne commented Nov 28, 2024

Motivation

missing_feature and bug actually execute the test, and ignore failures.

But it may happens that a test triggers a bug in the app that entirely break a payload, preventing other tests to execute. In that case, we don't want those tests to be executed (and yes, we'll loose the easy win feature).

Changes

Adds a force_skip argument to @missing_feature and @bug

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review November 28, 2024 20:07
@cbeauchesne cbeauchesne requested a review from a team as a code owner November 28, 2024 20:07
@cbeauchesne cbeauchesne merged commit 94cc7a9 into main Nov 28, 2024
@cbeauchesne cbeauchesne deleted the cbeauchesne/force-skip branch November 28, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant