-
Notifications
You must be signed in to change notification settings - Fork 15
Migrating compound extraction span link tests to weblog #3499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4a6b379
initial test for compound extraction with span links
mhlidd 9b248c5
updating PR with comments
mhlidd 4fb7b20
finish migrating all tests to weblog
mhlidd 939cd05
deleting old parametric tests and updating manifest files
mhlidd 4a38e92
updating manifests
mhlidd 1ca0914
cleanup
mhlidd cb9eca1
fixing ci error
mhlidd a8b9ef6
Apply suggestions from code review
mhlidd dd98552
responding to PR comments
mhlidd 73d2113
Merge branch 'main' into mhlidd/migrate_span_links_to_weblog
mhlidd c88b658
skipping node tests
mhlidd cdce0c0
adding comments to describe tests
mhlidd 13fe31d
Merge branch 'main' into mhlidd/migrate_span_links_to_weblog
mhlidd fa21916
Merge branch 'main' into mhlidd/migrate_span_links_to_weblog
mhlidd 8dffad7
reusing old weblog scenarios
mhlidd 54b4fab
Merge branch 'main' into mhlidd/migrate_span_links_to_weblog
cbeauchesne 08bf6b5
Skip test for spring-boot-3-native (APMAPI-928)
cbeauchesne f7368f8
Correct skip for APMAPI-928
cbeauchesne b31131f
removing spanid = 0 test
mhlidd fc77352
Merge branch 'main' into mhlidd/migrate_span_links_to_weblog
mhlidd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -105,6 +105,15 @@ def all_endtoend_scenarios(test_object): | |
| doc="Test W3C trace style", | ||
| ) | ||
|
|
||
| trace_propagation_style_w3c_datadog_b3 = EndToEndScenario( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should add the new scenarios here:. github/workflows/run-end-to-end.yml |
||
| "TRACE_PROPAGATION_STYLE_W3C_DATADOG_B3", | ||
|
cbeauchesne marked this conversation as resolved.
Outdated
|
||
| weblog_env={ | ||
| "DD_TRACE_PROPAGATION_STYLE_INJECT": "tracecontext,datadog,b3multi", | ||
| "DD_TRACE_PROPAGATION_STYLE_EXTRACT": "tracecontext,datadog,b3multi", | ||
| }, | ||
| doc="Test compound propagation trace style", | ||
| ) | ||
|
|
||
| # Telemetry scenarios | ||
| telemetry_dependency_loaded_test_for_dependency_collection_disabled = EndToEndScenario( | ||
| "TELEMETRY_DEPENDENCY_LOADED_TEST_FOR_DEPENDENCY_COLLECTION_DISABLED", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.