fix: decrement HashmapPidPageToMappingInfo metric on processPIDExit#79
Merged
Merged
Conversation
…open-telemetry#1400) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Gandem
approved these changes
May 11, 2026
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
martin.levesque@datadoghq.com cancelled this merge request build |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Author
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recently, we observed some unusual behavior regarding the
HashmapPidPageToMappingInfometric.According to the graph, we reached 163M entries in the eBPF map at one point, which seems way too high. When inspecting the actual map with:
$ bpftool -j map show id 31184 {"id":11696,"type":"lpm_trie","name":"pid_page_to_map","flags":1,"bytes_key":16,"bytes_value":16,"max_entries":1048576,"bytes_memlock":2120920,"frozen":0,"btf_id":99410}We are supposed to have a maximum of ~1M entries, so this value is definitely off.
Validating the changes
I tested by running both the unpatched and patched versions on separate nodes with identical workloads.
Without fix
With fix