-
Notifications
You must be signed in to change notification settings - Fork 2
Import simple telemetry implementation without native_deps and language interface implementation #50
Conversation
…ge interface implementation
🔥 |
I can't accept it while it's still in draft though |
663c4c3
to
df0be1f
Compare
Cargo.toml
Outdated
@@ -7,6 +7,7 @@ members = [ | |||
"ddprof-exporter", | |||
"ddprof-ffi", | |||
"ddprof-profiles", | |||
"telemetry", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, if the crate is ever pushed, this would be its exact name. I think it should be ddtelemetry
or dd-telemetry
or something -- not sure on the exact naming scheme. I was thinking about collapsing all the ddprof crates into just ddprof
or dd-prof
.
Or maybe we should spell them out datadog-*
, but dunno if we can get control of the datadog crate. Definitely not going to be able to get the dd crate ^_^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following dd-trace-*
example I think we could standardise on dd-
name for rust crates. BTW I just tested, and we can easily add libdatadog-owners
as owners of a crate.
4392fce
to
0e9bbf8
Compare
…/libddprof into pawel/merge_dd_telemetry
0c82125
to
ec8bd95
Compare
ec8bd95
to
a6cfe24
Compare
Initial merge of only telemetry related code from the telemetry shared library.
Python interface and additional cargo crates are planned to be merged later.