Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial move to use SendData in trace exporter (APMSP-1586) #753

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

ajgajg1134
Copy link
Contributor

@ajgajg1134 ajgajg1134 commented Nov 21, 2024

What does this PR do?

Moves TraceExporter to use trace utils send data functionality.

Motivation

We want access to the retry functionality of trace utils as well as to start supporting TinyBytes so we have good performance here

Additional Notes

There are a number of things to do after this is merged that have been commented out explicitly so that we can unblock others working in this area. (e.g. client stats)

How to test the change?

Covered with unit and integration tests for now

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-22 21:27:24

Comparing candidate commit 8a883de in PR branch andrew.glaude/traceExporterSendData with baseline commit 191a68a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 620.044µs 621.273µs ± 0.595µs 621.209µs ± 0.224µs 621.451µs 621.979µs 622.447µs 627.183µs 0.96% 5.463 49.676 0.10% 0.042µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1594432.158op/s 1609600.550op/s ± 1533.990op/s 1609763.495op/s ± 580.151op/s 1610319.313op/s 1611124.068op/s 1612366.734op/s 1612788.423op/s 0.19% -5.400 48.880 0.10% 108.469op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.312µs 467.243µs ± 0.582µs 467.168µs ± 0.172µs 467.375µs 467.750µs 467.948µs 474.348µs 1.54% 9.195 109.717 0.12% 0.041µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2108154.775op/s 2140217.501op/s ± 2634.153op/s 2140556.246op/s ± 788.512op/s 2141265.000op/s 2142121.473op/s 2143106.182op/s 2144488.405op/s 0.18% -9.095 108.073 0.12% 186.263op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.914µs 191.298µs ± 0.244µs 191.284µs ± 0.124µs 191.408µs 191.540µs 191.653µs 193.854µs 1.34% 5.772 58.725 0.13% 0.017µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5158513.856op/s 5227458.766op/s ± 6609.375op/s 5227832.282op/s ± 3386.925op/s 5231172.558op/s 5234577.912op/s 5236960.787op/s 5237950.699op/s 0.19% -5.669 57.308 0.13% 467.353op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.903µs 47.309µs ± 0.139µs 47.314µs ± 0.095µs 47.403µs 47.535µs 47.635µs 47.672µs 0.76% 0.026 -0.171 0.29% 0.010µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20976661.544op/s 21137871.480op/s ± 61887.421op/s 21135281.656op/s ± 42215.184op/s 21182785.589op/s 21237534.312op/s 21266932.509op/s 21320757.890op/s 0.88% -0.010 -0.169 0.29% 4376.101op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 51.465µs 51.604µs ± 0.070µs 51.600µs ± 0.056µs 51.659µs 51.712µs 51.760µs 51.784µs 0.36% 0.115 -0.749 0.14% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19311168.353op/s 19378549.696op/s ± 26339.376op/s 19379909.031op/s ± 21132.117op/s 19397888.425op/s 19419016.165op/s 19427918.965op/s 19430649.953op/s 0.26% -0.110 -0.752 0.14% 1862.475op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [621.190µs; 621.355µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1609387.953op/s; 1609813.146op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.162µs; 467.324µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2139852.433op/s; 2140582.570op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.264µs; 191.332µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5226542.770op/s; 5228374.762op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.290µs; 47.328µs] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21129294.479op/s; 21146448.481op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [51.594µs; 51.613µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19374899.312op/s; 19382200.080op/s] or [-0.019%; +0.019%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 298.966ns 311.509ns ± 14.244ns 305.848ns ± 5.081ns 314.026ns 343.491ns 354.428ns 364.008ns 19.02% 1.608 1.887 4.56% 1.007ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [309.535ns; 313.483ns] or [-0.634%; +0.634%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.619µs 4.632µs ± 0.007µs 4.631µs ± 0.003µs 4.634µs 4.638µs 4.641µs 4.718µs 1.87% 8.422 98.320 0.16% 0.001µs 1 200
credit_card/is_card_number/ throughput 211946935.320op/s 215898846.396op/s ± 334061.876op/s 215915567.515op/s ± 117056.327op/s 216033924.851op/s 216233427.625op/s 216289102.196op/s 216505674.625op/s 0.27% -8.285 96.188 0.15% 23621.742op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.840µs 91.707µs ± 0.579µs 91.602µs ± 0.301µs 91.962µs 92.571µs 92.732µs 96.933µs 5.82% 3.892 31.525 0.63% 0.041µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10316417.660op/s 10904769.533op/s ± 67245.689op/s 10916805.229op/s ± 35716.485op/s 10947471.569op/s 10984295.479op/s 10996646.669op/s 11008366.358op/s 0.84% -3.563 27.616 0.62% 4754.988op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.795µs 84.053µs ± 0.369µs 83.998µs ± 0.038µs 84.049µs 84.266µs 84.652µs 88.949µs 5.89% 11.872 154.278 0.44% 0.026µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11242396.267op/s 11897474.355op/s ± 49623.338op/s 11905041.190op/s ± 5395.926op/s 11909528.816op/s 11916891.006op/s 11925062.993op/s 11933836.005op/s 0.24% -11.669 150.518 0.42% 3508.900op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.621µs 4.633µs ± 0.006µs 4.633µs ± 0.003µs 4.635µs 4.641µs 4.645µs 4.695µs 1.33% 5.317 51.409 0.13% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 213005924.819op/s 215833870.284op/s ± 280630.106op/s 215848064.549op/s ± 119518.726op/s 215972064.016op/s 216150752.182op/s 216322098.362op/s 216401186.159op/s 0.26% -5.219 50.124 0.13% 19843.545op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.062µs 81.223µs ± 0.126µs 81.186µs ± 0.036µs 81.232µs 81.441µs 81.701µs 81.917µs 0.90% 2.417 8.011 0.15% 0.009µs 1 200
credit_card/is_card_number/378282246310005 throughput 12207499.934op/s 12311877.509op/s ± 18992.091op/s 12317405.637op/s ± 5482.704op/s 12321863.368op/s 12330447.767op/s 12335565.421op/s 12336300.280op/s 0.15% -2.398 7.875 0.15% 1342.944op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.017µs 59.266µs ± 0.167µs 59.249µs ± 0.130µs 59.368µs 59.565µs 59.718µs 59.771µs 0.88% 0.856 0.210 0.28% 0.012µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16730468.490op/s 16873318.136op/s ± 47302.960op/s 16877959.078op/s ± 36971.735op/s 16915555.969op/s 16927790.862op/s 16935172.304op/s 16944328.057op/s 0.39% -0.843 0.178 0.28% 3344.824op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.835µs 6.843µs ± 0.004µs 6.842µs ± 0.002µs 6.844µs 6.850µs 6.853µs 6.853µs 0.16% 0.791 0.731 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145914445.430op/s 146134221.791op/s ± 74974.759op/s 146146072.100op/s ± 36866.386op/s 146179396.015op/s 146236149.583op/s 146285102.979op/s 146300596.290op/s 0.11% -0.788 0.727 0.05% 5301.516op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.622µs 4.632µs ± 0.004µs 4.632µs ± 0.002µs 4.635µs 4.639µs 4.642µs 4.643µs 0.23% 0.226 -0.061 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215376871.635op/s 215877062.196op/s ± 182464.996op/s 215881125.076op/s ± 116563.767op/s 215992181.087op/s 216160251.508op/s 216263033.620op/s 216367001.708op/s 0.23% -0.221 -0.063 0.08% 12902.224op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.058µs 73.625µs ± 0.152µs 73.654µs ± 0.088µs 73.729µs 73.812µs 73.878µs 74.027µs 0.51% -0.994 1.356 0.21% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13508496.149op/s 13582364.686op/s ± 28014.219op/s 13576942.957op/s ± 16175.398op/s 13596570.265op/s 13638363.088op/s 13666382.006op/s 13687786.619op/s 0.82% 1.008 1.389 0.21% 1980.904op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 64.789µs 65.181µs ± 0.214µs 65.157µs ± 0.154µs 65.318µs 65.540µs 65.689µs 65.932µs 1.19% 0.585 0.087 0.33% 0.015µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15167221.075op/s 15342114.469op/s ± 50194.954op/s 15347581.880op/s ± 36387.889op/s 15381717.293op/s 15411220.799op/s 15431825.612op/s 15434683.277op/s 0.57% -0.568 0.050 0.33% 3549.319op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.619µs 4.633µs ± 0.004µs 4.632µs ± 0.003µs 4.635µs 4.640µs 4.642µs 4.645µs 0.27% 0.037 0.130 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215289310.342op/s 215860566.860op/s ± 195609.828op/s 215873382.812op/s ± 127230.277op/s 215985832.806op/s 216162703.638op/s 216299980.201op/s 216485615.238op/s 0.28% -0.032 0.132 0.09% 13831.704op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.810µs 63.513µs ± 0.161µs 63.544µs ± 0.080µs 63.612µs 63.708µs 63.774µs 63.918µs 0.59% -1.306 2.879 0.25% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15645158.304op/s 15744994.745op/s ± 40040.148op/s 15737115.274op/s ± 19858.366op/s 15762632.002op/s 15827000.154op/s 15880532.298op/s 15920938.634op/s 1.17% 1.330 2.961 0.25% 2831.266op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.043µs 59.380µs ± 0.239µs 59.345µs ± 0.201µs 59.558µs 59.810µs 59.900µs 60.051µs 1.19% 0.501 -0.764 0.40% 0.017µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16652385.686op/s 16841068.097op/s ± 67512.917op/s 16850517.615op/s ± 57217.687op/s 16904185.484op/s 16924372.621op/s 16932965.419op/s 16936842.714op/s 0.51% -0.489 -0.783 0.40% 4773.884op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.835µs 6.844µs ± 0.006µs 6.844µs ± 0.002µs 6.846µs 6.849µs 6.853µs 6.910µs 0.97% 8.110 92.817 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 144717599.739op/s 146107238.872op/s ± 118850.161op/s 146122182.633op/s ± 40282.847op/s 146154454.619op/s 146203045.429op/s 146267167.827op/s 146307374.982op/s 0.13% -8.039 91.719 0.08% 8403.975op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.631µs; 4.633µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number/ throughput [215852548.633op/s; 215945144.159op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.626µs; 91.787µs] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10895449.928op/s; 10914089.139op/s] or [-0.085%; +0.085%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.002µs; 84.104µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11890597.038op/s; 11904351.673op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/37828224631 execution_time [4.632µs; 4.634µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631 throughput [215794977.650op/s; 215872762.918op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.205µs; 81.240µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/378282246310005 throughput [12309245.387op/s; 12314509.630op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.243µs; 59.289µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16866762.400op/s; 16879873.871op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.843µs; 6.844µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [146123831.011op/s; 146144612.572op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.632µs; 4.633µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [215851774.302op/s; 215902350.089op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.604µs; 73.646µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13578482.185op/s; 13586247.188op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.151µs; 65.210µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15335157.931op/s; 15349071.007op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.632µs; 4.633µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215833457.219op/s; 215887676.501op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.490µs; 63.535µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15739445.566op/s; 15750543.925op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.347µs; 59.413µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16831711.456op/s; 16850424.738op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.844µs; 6.845µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146090767.383op/s; 146123710.362op/s] or [-0.011%; +0.011%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 302.412µs 305.566µs ± 1.426µs 305.453µs ± 1.000µs 306.606µs 307.982µs 308.648µs 308.920µs 1.14% 0.177 -0.605 0.47% 0.101µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3237083.259op/s 3272686.941op/s ± 15259.269op/s 3273824.701op/s ± 10742.745op/s 3283351.808op/s 3296926.011op/s 3303705.546op/s 3306751.137op/s 1.01% -0.158 -0.611 0.47% 1078.993op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.118µs 28.274µs ± 0.066µs 28.272µs ± 0.052µs 28.319µs 28.393µs 28.419µs 28.441µs 0.60% 0.311 -0.519 0.23% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35160626.589op/s 35368932.544op/s ± 82587.431op/s 35370955.447op/s ± 64636.011op/s 35437213.441op/s 35483993.143op/s 35522062.947op/s 35565015.242op/s 0.55% -0.301 -0.525 0.23% 5839.813op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.566µs 16.712µs ± 0.063µs 16.711µs ± 0.046µs 16.756µs 16.815µs 16.859µs 16.874µs 0.97% 0.087 -0.343 0.37% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 59264302.072op/s 59838162.138op/s ± 224013.382op/s 59840915.233op/s ± 163722.887op/s 60017905.371op/s 60172672.835op/s 60316532.705op/s 60365692.268op/s 0.88% -0.069 -0.351 0.37% 15840.138op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [305.368µs; 305.764µs] or [-0.065%; +0.065%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3270572.153op/s; 3274801.729op/s] or [-0.065%; +0.065%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.264µs; 28.283µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35357486.721op/s; 35380378.368op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.703µs; 16.721µs] or [-0.052%; +0.052%] None None None
normalization/normalize_name/normalize_name/good throughput [59807116.037op/s; 59869208.238op/s] or [-0.052%; +0.052%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.316µs 24.488µs ± 14.069µs 18.718µs ± 0.105µs 19.555µs 46.246µs 48.933µs 156.595µs 736.58% 5.293 41.246 57.31% 0.995µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.538µs; 26.438µs] or [-7.963%; +7.963%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.419µs 3.256µs ± 1.433µs 3.100µs ± 0.021µs 3.118µs 3.158µs 14.261µs 15.239µs 391.55% 7.642 58.260 43.90% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.057µs; 3.455µs] or [-6.100%; +6.100%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.154µs 38.692µs ± 0.866µs 38.285µs ± 0.057µs 38.413µs 40.548µs 40.622µs 41.396µs 8.12% 1.707 1.025 2.23% 0.061µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.572µs; 38.812µs] or [-0.310%; +0.310%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.086µs 69.219µs ± 0.148µs 69.194µs ± 0.035µs 69.237µs 69.318µs 70.027µs 70.749µs 2.25% 7.191 63.393 0.21% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.198µs; 69.239µs] or [-0.030%; +0.030%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.745µs 138.615µs ± 0.324µs 138.568µs ± 0.153µs 138.741µs 139.281µs 139.717µs 139.916µs 0.97% 1.123 2.843 0.23% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.570µs; 138.660µs] or [-0.032%; +0.032%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.534ms 60.693ms ± 0.128ms 60.672ms ± 0.041ms 60.715ms 60.828ms 61.216ms 61.653ms 1.62% 4.735 30.002 0.21% 0.009ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.676ms; 60.711ms] or [-0.029%; +0.029%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.140ms 9.173ms ± 0.017ms 9.172ms ± 0.011ms 9.183ms 9.197ms 9.230ms 9.275ms 1.12% 1.700 6.969 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.171ms; 9.176ms] or [-0.026%; +0.026%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8a883de 1732310182 andrew.glaude/traceExporterSendData
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.628µs 2.684µs ± 0.016µs 2.686µs ± 0.007µs 2.691µs 2.713µs 2.719µs 2.719µs 1.23% -0.817 2.308 0.58% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.682µs; 2.686µs] or [-0.081%; +0.081%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 88.17204% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.50%. Comparing base (191a68a) to head (8a883de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   70.79%   70.50%   -0.30%     
==========================================
  Files         297      297              
  Lines       43568    43385     -183     
==========================================
- Hits        30843    30587     -256     
- Misses      12725    12798      +73     
Components Coverage Δ
crashtracker 43.80% <ø> (ø)
crashtracker-ffi 8.67% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 89.09% <88.17%> (-2.89%) ⬇️
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.05% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.36% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.29% <ø> (-0.25%) ⬇️
---- 🚨 Try these New Features:

@ajgajg1134 ajgajg1134 marked this pull request as ready for review November 22, 2024 18:52
@ajgajg1134 ajgajg1134 requested review from a team as code owners November 22, 2024 18:52
Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rough, to use your words but LGTM since we're addressing all the issues imminently.

data-pipeline/src/trace_exporter.rs Outdated Show resolved Hide resolved
data-pipeline/src/health_metrics.rs Outdated Show resolved Hide resolved
data-pipeline/src/trace_exporter.rs Outdated Show resolved Hide resolved
data-pipeline/src/trace_exporter.rs Outdated Show resolved Hide resolved
data-pipeline/src/trace_exporter.rs Outdated Show resolved Hide resolved
@ekump
Copy link
Contributor

ekump commented Nov 22, 2024

Please associate a Jira ticket to this PR before merging.

@ajgajg1134 ajgajg1134 changed the title Initial move to use SendData in trace exporter Initial move to use SendData in trace exporter (APMSP-1586) Nov 22, 2024
@hoolioh hoolioh self-requested a review November 25, 2024 08:43
@hoolioh
Copy link
Contributor

hoolioh commented Nov 25, 2024

Despite the compromises we need to make it LGTM.

@ajgajg1134 ajgajg1134 merged commit 25079f5 into main Nov 25, 2024
32 checks passed
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/traceExporterSendData branch November 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants