Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve err message #745

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Improve err message #745

merged 1 commit into from
Nov 15, 2024

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

improve error message

Motivation

It took me a few minutes to figure out why these tests weren't running, this should help next time :)

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@ajgajg1134 ajgajg1134 requested review from a team as code owners November 15, 2024 20:29
@ajgajg1134 ajgajg1134 enabled auto-merge (squash) November 15, 2024 20:35
@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-15 20:39:56

Comparing candidate commit 0ab754b in PR branch andrew.glaude/snaptests with baseline commit fc132d5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.353µs 507.196µs ± 0.354µs 507.199µs ± 0.255µs 507.416µs 507.792µs 507.940µs 508.050µs 0.17% 0.120 -0.469 0.07% 0.025µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1968311.801op/s 1971624.802op/s ± 1377.613op/s 1971613.292op/s ± 992.207op/s 1972664.670op/s 1973653.445op/s 1974593.415op/s 1974908.669op/s 0.17% -0.116 -0.470 0.07% 97.412op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.610µs 468.189µs ± 0.307µs 468.164µs ± 0.207µs 468.390µs 468.683µs 468.964µs 469.653µs 0.32% 0.717 1.792 0.07% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2129232.775op/s 2135888.528op/s ± 1400.741op/s 2136003.743op/s ± 945.702op/s 2136846.819op/s 2138053.327op/s 2138453.451op/s 2138535.693op/s 0.12% -0.711 1.766 0.07% 99.047op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.753µs 180.251µs ± 0.177µs 180.251µs ± 0.131µs 180.373µs 180.525µs 180.720µs 180.812µs 0.31% 0.299 -0.007 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5530613.836op/s 5547815.636op/s ± 5451.015op/s 5547822.432op/s ± 4030.008op/s 5551964.270op/s 5555875.320op/s 5557629.442op/s 5563182.694op/s 0.28% -0.293 -0.013 0.10% 385.445op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.777µs 44.946µs ± 0.066µs 44.944µs ± 0.046µs 44.993µs 45.057µs 45.088µs 45.134µs 0.42% 0.155 -0.384 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22156141.400op/s 22248957.285op/s ± 32497.912op/s 22249977.721op/s ± 22722.273op/s 22271802.872op/s 22297120.907op/s 22312603.022op/s 22333120.509op/s 0.37% -0.148 -0.386 0.15% 2297.949op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.011µs 49.177µs ± 0.081µs 49.157µs ± 0.054µs 49.233µs 49.314µs 49.364µs 49.452µs 0.60% 0.593 -0.028 0.16% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20221494.354op/s 20334711.744op/s ± 33515.211op/s 20342929.175op/s ± 22331.010op/s 20358829.158op/s 20379577.800op/s 20398033.941op/s 20403744.495op/s 0.30% -0.585 -0.043 0.16% 2369.883op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.147µs; 507.245µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1971433.878op/s; 1971815.726op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.147µs; 468.232µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2135694.399op/s; 2136082.658op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.227µs; 180.276µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5547060.177op/s; 5548571.094op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.937µs; 44.955µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22244453.387op/s; 22253461.183op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.166µs; 49.188µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20330066.858op/s; 20339356.630op/s] or [-0.023%; +0.023%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.599µs 4.613µs ± 0.009µs 4.612µs ± 0.006µs 4.619µs 4.628µs 4.632µs 4.633µs 0.46% 0.349 -0.687 0.19% 0.001µs 1 200
credit_card/is_card_number/ throughput 215838549.183op/s 216783979.249op/s ± 402194.893op/s 216831112.793op/s ± 284423.224op/s 217094049.596op/s 217385927.114op/s 217406157.409op/s 217416254.897op/s 0.27% -0.343 -0.693 0.19% 28439.474op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 93.172µs 93.472µs ± 0.327µs 93.434µs ± 0.088µs 93.527µs 93.691µs 94.093µs 97.652µs 4.51% 10.605 132.060 0.35% 0.023µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10240454.485op/s 10698520.840op/s ± 36106.300op/s 10702685.839op/s ± 10113.920op/s 10712129.614op/s 10717316.504op/s 10721585.289op/s 10732860.800op/s 0.28% -10.379 128.093 0.34% 2553.101op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.213µs 85.362µs ± 0.304µs 85.310µs ± 0.022µs 85.339µs 85.626µs 86.137µs 89.121µs 4.47% 9.919 115.697 0.36% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11220714.885op/s 11714907.342op/s ± 40337.964op/s 11721937.173op/s ± 3049.118op/s 11724495.713op/s 11728635.126op/s 11731900.041op/s 11735297.438op/s 0.11% -9.716 111.870 0.34% 2852.325op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.599µs 4.613µs ± 0.008µs 4.612µs ± 0.006µs 4.618µs 4.627µs 4.631µs 4.634µs 0.47% 0.277 -0.560 0.18% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 215814431.826op/s 216800818.759op/s ± 387561.268op/s 216829021.023op/s ± 276522.815op/s 217095255.517op/s 217379298.528op/s 217412878.067op/s 217416865.113op/s 0.27% -0.270 -0.568 0.18% 27404.720op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.632µs 82.032µs ± 0.185µs 82.045µs ± 0.097µs 82.126µs 82.294µs 82.509µs 83.320µs 1.55% 1.775 10.818 0.22% 0.013µs 1 200
credit_card/is_card_number/378282246310005 throughput 12001896.693op/s 12190460.636op/s ± 27328.982op/s 12188417.364op/s ± 14378.501op/s 12208956.491op/s 12227618.235op/s 12239698.692op/s 12250115.221op/s 0.51% -1.711 10.304 0.22% 1932.451op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.857µs 58.890µs ± 0.019µs 58.891µs ± 0.015µs 58.902µs 58.927µs 58.944µs 58.950µs 0.10% 0.626 -0.126 0.03% 0.001µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16963389.613op/s 16980745.637op/s ± 5594.936op/s 16980581.856op/s ± 4426.050op/s 16985436.687op/s 16987737.062op/s 16989160.202op/s 16990405.518op/s 0.06% -0.624 -0.130 0.03% 395.622op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.819µs 6.832µs ± 0.022µs 6.824µs ± 0.003µs 6.828µs 6.875µs 6.906µs 6.985µs 2.36% 3.160 12.929 0.33% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 143166381.119op/s 146367075.278op/s ± 473361.158op/s 146549706.140op/s ± 62764.492op/s 146608224.019op/s 146631242.676op/s 146639132.056op/s 146646592.467op/s 0.07% -3.113 12.455 0.32% 33471.688op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.599µs 4.612µs ± 0.008µs 4.612µs ± 0.006µs 4.618µs 4.629µs 4.630µs 4.630µs 0.40% 0.349 -0.638 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215979666.032op/s 216819403.544op/s ± 389016.044op/s 216845408.168op/s ± 276627.826op/s 217098695.270op/s 217393334.890op/s 217416946.458op/s 217417465.602op/s 0.26% -0.342 -0.645 0.18% 27507.588op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.395µs 73.713µs ± 0.123µs 73.738µs ± 0.056µs 73.777µs 73.885µs 73.942µs 74.513µs 1.05% 0.918 7.946 0.17% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13420451.801op/s 13566100.370op/s ± 22683.759op/s 13561590.188op/s ± 10279.370op/s 13581420.617op/s 13607264.852op/s 13619890.843op/s 13624989.593op/s 0.47% -0.873 7.655 0.17% 1603.984op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.276µs 65.535µs ± 0.141µs 65.533µs ± 0.104µs 65.640µs 65.725µs 65.810µs 66.294µs 1.16% 0.712 2.965 0.21% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15084391.254op/s 15259128.093op/s ± 32756.170op/s 15259525.635op/s ± 24075.948op/s 15282289.358op/s 15314425.960op/s 15317990.598op/s 15319609.100op/s 0.39% -0.683 2.815 0.21% 2316.211op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.599µs 4.611µs ± 0.008µs 4.611µs ± 0.006µs 4.617µs 4.626µs 4.630µs 4.632µs 0.44% 0.427 -0.634 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215905195.222op/s 216851197.829op/s ± 394116.132op/s 216864672.755op/s ± 288518.994op/s 217228221.032op/s 217389254.083op/s 217415173.734op/s 217427479.064op/s 0.26% -0.421 -0.642 0.18% 27868.219op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.137µs 62.538µs ± 0.121µs 62.510µs ± 0.041µs 62.594µs 62.745µs 62.909µs 62.990µs 0.77% 0.467 1.826 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15875659.468op/s 15990308.906op/s ± 30884.886op/s 15997440.411op/s ± 10557.083op/s 16005312.571op/s 16040287.704op/s 16058058.543op/s 16093406.531op/s 0.60% -0.446 1.815 0.19% 2183.891op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.867µs 58.901µs ± 0.020µs 58.901µs ± 0.015µs 58.914µs 58.933µs 58.954µs 58.988µs 0.15% 0.782 1.174 0.03% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16952551.504op/s 16977767.860op/s ± 5629.496op/s 16977566.692op/s ± 4337.997op/s 16982814.665op/s 16985101.179op/s 16986037.969op/s 16987410.630op/s 0.06% -0.779 1.163 0.03% 398.065op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.819µs 6.835µs ± 0.027µs 6.824µs ± 0.002µs 6.826µs 6.901µs 6.910µs 7.009µs 2.72% 2.951 11.002 0.40% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 142670243.168op/s 146310905.123op/s ± 578147.406op/s 146548270.213op/s ± 49864.498op/s 146597852.128op/s 146628682.093op/s 146635031.614op/s 146644735.399op/s 0.07% -2.901 10.531 0.39% 40881.195op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.612µs; 4.614µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/ throughput [216728238.905op/s; 216839719.593op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.427µs; 93.517µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10693516.854op/s; 10703524.826op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [85.320µs; 85.405µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11709316.888op/s; 11720497.796op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631 execution_time [4.611µs; 4.614µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/37828224631 throughput [216747106.495op/s; 216854531.023op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/378282246310005 execution_time [82.006µs; 82.057µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/378282246310005 throughput [12186673.102op/s; 12194248.171op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.888µs; 58.893µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16979970.233op/s; 16981521.041op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.829µs; 6.835µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number/x371413321323331 throughput [146301471.974op/s; 146432678.581op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.611µs; 4.613µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ throughput [216765489.662op/s; 216873317.427op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.696µs; 73.730µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13562956.620op/s; 13569244.121op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.515µs; 65.554µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15254588.403op/s; 15263667.784op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.610µs; 4.613µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216796577.123op/s; 216905818.534op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.521µs; 62.555µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15986028.558op/s; 15994589.254op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.898µs; 58.903µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16976987.666op/s; 16978548.054op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.831µs; 6.839µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146230779.453op/s; 146391030.793op/s] or [-0.055%; +0.055%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.375µs 3.290µs ± 1.423µs 3.141µs ± 0.024µs 3.162µs 3.203µs 14.165µs 15.202µs 383.90% 7.555 57.358 43.13% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.093µs; 3.487µs] or [-5.992%; +5.992%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.325µs 69.494µs ± 0.138µs 69.471µs ± 0.036µs 69.510µs 69.659µs 69.884µs 70.993µs 2.19% 6.933 69.126 0.20% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.475µs; 69.513µs] or [-0.027%; +0.027%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.638µs 2.699µs ± 0.016µs 2.699µs ± 0.006µs 2.705µs 2.730µs 2.739µs 2.747µs 1.78% -0.712 3.642 0.60% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.696µs; 2.701µs] or [-0.083%; +0.083%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.011ms 9.052ms ± 0.014ms 9.053ms ± 0.010ms 9.062ms 9.075ms 9.082ms 9.091ms 0.42% -0.179 -0.089 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.050ms; 9.054ms] or [-0.022%; +0.022%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 272.096µs 273.324µs ± 0.740µs 273.265µs ± 0.500µs 273.789µs 274.670µs 275.258µs 275.662µs 0.88% 0.600 -0.055 0.27% 0.052µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3627628.746op/s 3658684.674op/s ± 9890.019op/s 3659452.787op/s ± 6710.536op/s 3666052.328op/s 3673318.197op/s 3674773.104op/s 3675176.620op/s 0.43% -0.587 -0.077 0.27% 699.330op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.939µs 26.072µs ± 0.076µs 26.055µs ± 0.046µs 26.112µs 26.214µs 26.267µs 26.324µs 1.03% 0.737 -0.029 0.29% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37987716.122op/s 38356074.956op/s ± 110984.463op/s 38379839.901op/s ± 67869.826op/s 38436928.193op/s 38500483.184op/s 38537746.284op/s 38552126.258op/s 0.45% -0.725 -0.055 0.29% 7847.787op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.477µs 15.583µs ± 0.071µs 15.589µs ± 0.050µs 15.621µs 15.713µs 15.769µs 15.784µs 1.25% 0.453 -0.268 0.45% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 63355497.198op/s 64172381.505op/s ± 290872.288op/s 64146133.484op/s ± 204854.662op/s 64479963.067op/s 64554400.075op/s 64584246.704op/s 64610056.771op/s 0.72% -0.432 -0.307 0.45% 20567.777op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.222µs; 273.427µs] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3657314.012op/s; 3660055.335op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [26.061µs; 26.082µs] or [-0.040%; +0.040%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38340693.577op/s; 38371456.336op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.574µs; 15.593µs] or [-0.063%; +0.063%] None None None
normalization/normalize_name/normalize_name/good throughput [64132069.404op/s; 64212693.607op/s] or [-0.063%; +0.063%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.507ns 305.527ns ± 14.094ns 298.996ns ± 3.935ns 308.739ns 339.798ns 340.378ns 341.059ns 14.07% 1.423 0.638 4.60% 0.997ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [303.573ns; 307.480ns] or [-0.639%; +0.639%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.504µs 141.459µs ± 0.427µs 141.428µs ± 0.176µs 141.604µs 142.017µs 142.973µs 144.126µs 1.91% 2.183 10.119 0.30% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [141.400µs; 141.518µs] or [-0.042%; +0.042%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.303ms 59.743ms ± 0.354ms 59.614ms ± 0.173ms 59.960ms 60.439ms 60.795ms 61.560ms 3.26% 1.598 3.725 0.59% 0.025ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.694ms; 59.792ms] or [-0.082%; +0.082%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.823µs 37.290µs ± 0.773µs 36.948µs ± 0.060µs 37.030µs 38.928µs 38.960µs 40.352µs 9.21% 1.780 1.538 2.07% 0.055µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.183µs; 37.397µs] or [-0.287%; +0.287%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0ab754b 1731702538 andrew.glaude/snaptests
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.327µs 27.673µs ± 11.483µs 19.473µs ± 0.697µs 36.393µs 37.186µs 46.569µs 115.187µs 491.51% 3.018 18.700 41.39% 0.812µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.082µs; 29.265µs] or [-5.751%; +5.751%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.56%. Comparing base (fc132d5) to head (0ab754b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   70.54%   70.56%   +0.02%     
==========================================
  Files         296      296              
  Lines       43277    43277              
==========================================
+ Hits        30530    30539       +9     
+ Misses      12747    12738       -9     
Components Coverage Δ
crashtracker 37.14% <ø> (ø)
crashtracker-ffi 8.67% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.95% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (-0.11%) ⬇️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.03% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.18% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.15% <100.00%> (ø)

@ajgajg1134 ajgajg1134 merged commit 4660457 into main Nov 15, 2024
32 checks passed
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/snaptests branch November 15, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants