Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Fixup link in RFC #737

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[crashtracker] Fixup link in RFC #737

merged 1 commit into from
Nov 13, 2024

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Fixes a link in the RFC to point at the right file.

Motivation

Oops!

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Click the new link, see it works.

@danielsn danielsn requested a review from a team as a code owner November 13, 2024 20:51
@danielsn danielsn enabled auto-merge (squash) November 13, 2024 20:54
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-13 21:01:47

Comparing candidate commit 6a1d59c in PR branch dsn/fix-rfc-link with baseline commit 93babcf in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+2.464ms; +2.561ms] or [+4.113%; +4.273%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 292.466ns 305.444ns ± 14.937ns 299.949ns ± 4.758ns 308.467ns 340.628ns 356.099ns 358.590ns 19.55% 1.990 3.300 4.88% 1.056ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [303.374ns; 307.514ns] or [-0.678%; +0.678%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 271.915µs 273.394µs ± 0.818µs 273.360µs ± 0.579µs 273.853µs 274.933µs 275.386µs 275.689µs 0.85% 0.402 -0.302 0.30% 0.058µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3627277.416op/s 3657759.013op/s ± 10934.955op/s 3658173.445op/s ± 7746.239op/s 3666320.026op/s 3674267.199op/s 3677008.405op/s 3677613.984op/s 0.53% -0.388 -0.318 0.30% 773.218op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.816µs 26.289µs ± 0.239µs 26.286µs ± 0.177µs 26.465µs 26.691µs 26.782µs 26.909µs 2.37% 0.059 -0.671 0.91% 0.017µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37162197.363op/s 38041285.916op/s ± 345246.087op/s 38043504.835op/s ± 254987.657op/s 38290398.373op/s 38622727.265op/s 38698309.940op/s 38736004.356op/s 1.82% -0.023 -0.685 0.91% 24412.585op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.479µs 15.620µs ± 0.096µs 15.665µs ± 0.064µs 15.699µs 15.731µs 15.750µs 16.032µs 2.34% 0.128 -0.114 0.61% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 62375086.028op/s 64020974.031op/s ± 393697.557op/s 63834660.831op/s ± 258286.764op/s 64470148.840op/s 64563213.449op/s 64591313.042op/s 64604638.613op/s 1.21% -0.094 -0.256 0.61% 27838.621op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.280µs; 273.507µs] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3656243.533op/s; 3659274.493op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [26.256µs; 26.322µs] or [-0.126%; +0.126%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [37993438.129op/s; 38089133.703op/s] or [-0.126%; +0.126%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.607µs; 15.634µs] or [-0.085%; +0.085%] None None None
normalization/normalize_name/normalize_name/good throughput [63966411.336op/s; 64075536.726op/s] or [-0.085%; +0.085%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.931µs 26.533µs ± 11.264µs 20.884µs ± 0.421µs 34.451µs 44.704µs 48.274µs 104.786µs 401.74% 3.012 14.401 42.35% 0.797µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.971µs; 28.094µs] or [-5.884%; +5.884%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.632µs 2.696µs ± 0.019µs 2.696µs ± 0.005µs 2.702µs 2.728µs 2.744µs 2.748µs 1.94% -0.918 3.826 0.69% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.693µs; 2.698µs] or [-0.096%; +0.096%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 62.148ms 62.430ms ± 0.174ms 62.400ms ± 0.086ms 62.495ms 62.738ms 63.148ms 63.400ms 1.60% 2.248 7.998 0.28% 0.012ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [62.406ms; 62.454ms] or [-0.039%; +0.039%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.600µs 4.612µs ± 0.008µs 4.612µs ± 0.006µs 4.618µs 4.627µs 4.630µs 4.632µs 0.44% 0.321 -0.577 0.17% 0.001µs 1 200
credit_card/is_card_number/ throughput 215903411.443op/s 216803134.870op/s ± 359636.619op/s 216845777.718op/s ± 261895.646op/s 217052327.525op/s 217367430.182op/s 217392558.713op/s 217399823.935op/s 0.26% -0.314 -0.583 0.17% 25430.149op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 93.028µs 93.558µs ± 0.352µs 93.522µs ± 0.028µs 93.543µs 93.713µs 94.322µs 98.057µs 4.85% 10.746 132.468 0.38% 0.025µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10198163.663op/s 10688735.535op/s ± 38667.121op/s 10692679.792op/s ± 3175.564op/s 10696210.867op/s 10709490.162op/s 10717431.237op/s 10749440.979op/s 0.53% -10.533 128.545 0.36% 2734.178op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.244µs 85.383µs ± 0.343µs 85.323µs ± 0.026µs 85.350µs 85.877µs 86.141µs 89.578µs 4.99% 9.621 110.634 0.40% 0.024µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11163495.446op/s 11712105.140op/s ± 45346.515op/s 11720195.431op/s ± 3547.002op/s 11723513.162op/s 11728201.942op/s 11730518.578op/s 11730965.614op/s 0.09% -9.383 106.221 0.39% 3206.483op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.593µs 4.612µs ± 0.008µs 4.612µs ± 0.006µs 4.618µs 4.625µs 4.631µs 4.633µs 0.45% 0.253 -0.487 0.17% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 215863939.436op/s 216832840.132op/s ± 373025.227op/s 216845214.061op/s ± 267135.702op/s 217094380.893op/s 217386736.513op/s 217419445.500op/s 217734554.775op/s 0.41% -0.245 -0.494 0.17% 26376.867op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.655µs 82.022µs ± 0.187µs 81.999µs ± 0.130µs 82.127µs 82.327µs 82.526µs 82.876µs 1.07% 0.759 1.533 0.23% 0.013µs 1 200
credit_card/is_card_number/378282246310005 throughput 12066248.054op/s 12191899.869op/s ± 27675.661op/s 12195281.658op/s ± 19348.605op/s 12215082.267op/s 12228904.185op/s 12242558.922op/s 12246704.030op/s 0.42% -0.739 1.458 0.23% 1956.965op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.858µs 58.964µs ± 0.068µs 58.970µs ± 0.061µs 59.019µs 59.080µs 59.110µs 59.135µs 0.28% 0.301 -0.956 0.11% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16910371.648op/s 16959656.852op/s ± 19459.388op/s 16957641.513op/s ± 17668.125op/s 16977417.064op/s 16985408.685op/s 16987119.805op/s 16989957.236op/s 0.19% -0.298 -0.960 0.11% 1375.986op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.819µs 6.833µs ± 0.023µs 6.824µs ± 0.003µs 6.827µs 6.893µs 6.902µs 6.924µs 1.47% 2.117 3.708 0.33% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 144429465.111op/s 146342871.476op/s ± 479267.660op/s 146548061.905op/s ± 55723.128op/s 146601544.727op/s 146632651.567op/s 146638494.435op/s 146654316.829op/s 0.07% -2.105 3.642 0.33% 33889.341op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.599µs 4.613µs ± 0.008µs 4.612µs ± 0.006µs 4.618µs 4.625µs 4.629µs 4.631µs 0.40% 0.144 -0.737 0.16% 0.001µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215958453.972op/s 216799848.235op/s ± 356172.180op/s 216828770.340op/s ± 301103.786op/s 217108054.700op/s 217359112.064op/s 217399586.527op/s 217436874.168op/s 0.28% -0.138 -0.742 0.16% 25185.176op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.397µs 73.726µs ± 0.149µs 73.739µs ± 0.086µs 73.806µs 73.916µs 74.022µs 74.904µs 1.58% 2.274 17.877 0.20% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13350356.347op/s 13563780.360op/s ± 27356.875op/s 13561268.340op/s ± 15873.185op/s 13578445.577op/s 13604259.158op/s 13615875.704op/s 13624577.375op/s 0.47% -2.186 17.055 0.20% 1934.423op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.272µs 65.487µs ± 0.125µs 65.480µs ± 0.092µs 65.569µs 65.696µs 65.713µs 65.720µs 0.37% 0.137 -0.956 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15215977.373op/s 15270271.340op/s ± 29106.840op/s 15271763.274op/s ± 21530.573op/s 15293505.613op/s 15316566.552op/s 15319633.934op/s 15320554.055op/s 0.32% -0.131 -0.958 0.19% 2058.164op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.599µs 4.613µs ± 0.008µs 4.612µs ± 0.005µs 4.618µs 4.627µs 4.630µs 4.632µs 0.44% 0.333 -0.448 0.17% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215892644.919op/s 216795049.301op/s ± 361015.876op/s 216846926.720op/s ± 255391.407op/s 217058018.238op/s 217383145.998op/s 217418128.708op/s 217426476.470op/s 0.27% -0.325 -0.455 0.17% 25527.677op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.226µs 62.532µs ± 0.112µs 62.514µs ± 0.039µs 62.583µs 62.715µs 62.838µs 62.962µs 0.72% 0.657 1.805 0.18% 0.008µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15882519.078op/s 15991827.000op/s ± 28506.555op/s 15996417.597op/s ± 10104.315op/s 16004320.173op/s 16037622.471op/s 16049773.207op/s 16070382.285op/s 0.46% -0.639 1.778 0.18% 2015.718op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.862µs 58.892µs ± 0.020µs 58.893µs ± 0.016µs 58.906µs 58.925µs 58.945µs 58.972µs 0.13% 0.648 0.261 0.03% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16957176.347op/s 16980137.482op/s ± 5789.806op/s 16979899.196op/s ± 4735.179op/s 16985398.502op/s 16987115.528op/s 16988330.563op/s 16989001.321op/s 0.05% -0.646 0.254 0.03% 409.401op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.819µs 6.834µs ± 0.029µs 6.824µs ± 0.003µs 6.827µs 6.899µs 6.945µs 7.065µs 3.54% 3.964 21.234 0.43% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 141536969.592op/s 146330624.602op/s ± 620946.238op/s 146544722.363op/s ± 60404.150op/s 146603149.658op/s 146630533.816op/s 146638199.158op/s 146649465.677op/s 0.07% -3.870 20.098 0.42% 43907.530op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.611µs; 4.614µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/ throughput [216753292.693op/s; 216852977.046op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.509µs; 93.606µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10683376.644op/s; 10694094.426op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [85.336µs; 85.431µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11705820.549op/s; 11718389.731op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631 execution_time [4.611µs; 4.613µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number/37828224631 throughput [216781142.424op/s; 216884537.841op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.996µs; 82.048µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/378282246310005 throughput [12188064.289op/s; 12195735.450op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.954µs; 58.973µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16956959.968op/s; 16962353.735op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.830µs; 6.836µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/x371413321323331 throughput [146276449.588op/s; 146409293.364op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.612µs; 4.614µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ throughput [216750486.196op/s; 216849210.273op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.705µs; 73.747µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13559988.960op/s; 13567571.760op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.470µs; 65.504µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15266237.412op/s; 15274305.269op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.612µs; 4.614µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216745015.973op/s; 216845082.630op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.517µs; 62.548µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15987876.265op/s; 15995777.734op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.890µs; 58.895µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16979335.070op/s; 16980939.893op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.830µs; 6.838µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146244567.425op/s; 146416681.778op/s] or [-0.059%; +0.059%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.349µs 3.285µs ± 1.422µs 3.135µs ± 0.025µs 3.157µs 3.206µs 14.024µs 15.023µs 379.25% 7.535 57.088 43.18% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.088µs; 3.482µs] or [-5.999%; +5.999%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.549µs 37.046µs ± 0.875µs 36.659µs ± 0.051µs 36.713µs 38.919µs 38.962µs 40.029µs 9.19% 1.739 1.169 2.36% 0.062µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.925µs; 37.168µs] or [-0.327%; +0.327%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.003ms 9.049ms ± 0.040ms 9.048ms ± 0.010ms 9.057ms 9.069ms 9.086ms 9.473ms 4.71% 7.940 75.426 0.44% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.044ms; 9.055ms] or [-0.061%; +0.061%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.456µs 507.551µs ± 0.493µs 507.497µs ± 0.255µs 507.776µs 508.377µs 509.332µs 509.604µs 0.42% 1.002 2.663 0.10% 0.035µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1962308.441op/s 1970245.282op/s ± 1910.866op/s 1970453.171op/s ± 991.040op/s 1971355.223op/s 1972999.559op/s 1974124.977op/s 1974504.730op/s 0.21% -0.991 2.630 0.10% 135.119op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.828µs 468.639µs ± 0.389µs 468.608µs ± 0.210µs 468.840µs 469.098µs 469.408µs 472.143µs 0.75% 3.640 31.318 0.08% 0.028µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2118002.149op/s 2133842.248op/s ± 1766.670op/s 2133977.510op/s ± 956.979op/s 2134848.312op/s 2136104.844op/s 2137036.775op/s 2137536.285op/s 0.17% -3.591 30.755 0.08% 124.922op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.818µs 180.264µs ± 0.201µs 180.240µs ± 0.126µs 180.362µs 180.648µs 180.913µs 180.958µs 0.40% 0.841 0.926 0.11% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5526148.657op/s 5547430.100op/s ± 6188.315op/s 5548148.627op/s ± 3885.750op/s 5552052.609op/s 5555664.261op/s 5557451.457op/s 5561175.508op/s 0.23% -0.833 0.908 0.11% 437.580op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.911µs 45.135µs ± 0.062µs 45.133µs ± 0.040µs 45.175µs 45.230µs 45.272µs 45.301µs 0.37% -0.114 0.365 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22074668.113op/s 22155963.249op/s ± 30195.225op/s 22156942.180op/s ± 19605.914op/s 22174396.122op/s 22198377.267op/s 22226078.787op/s 22266154.450op/s 0.49% 0.124 0.375 0.14% 2135.125op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.914µs 49.122µs ± 0.082µs 49.109µs ± 0.056µs 49.180µs 49.265µs 49.309µs 49.376µs 0.54% 0.391 -0.276 0.17% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20252599.957op/s 20357329.241op/s ± 33810.306op/s 20362897.986op/s ± 23090.614op/s 20382986.730op/s 20405774.591op/s 20425246.674op/s 20443990.561op/s 0.40% -0.383 -0.282 0.17% 2390.750op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.483µs; 507.620µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1969980.455op/s; 1970510.110op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.585µs; 468.692µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2133597.404op/s; 2134087.091op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.236µs; 180.292µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5546572.459op/s; 5548287.741op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.126µs; 45.143µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22151778.481op/s; 22160148.016op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.111µs; 49.134µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20352643.458op/s; 20362015.024op/s] or [-0.023%; +0.023%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.289µs 142.349µs ± 0.468µs 142.328µs ± 0.186µs 142.521µs 142.854µs 143.236µs 147.067µs 3.33% 5.068 50.208 0.33% 0.033µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.284µs; 142.414µs] or [-0.046%; +0.046%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6a1d59c 1731531038 dsn/fix-rfc-link
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.462µs 69.578µs ± 0.121µs 69.569µs ± 0.021µs 69.590µs 69.620µs 69.695µs 71.155µs 2.28% 11.368 144.778 0.17% 0.009µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.561µs; 69.594µs] or [-0.024%; +0.024%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (93babcf) to head (6a1d59c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   71.01%   71.05%   +0.03%     
==========================================
  Files         287      287              
  Lines       42836    42836              
==========================================
+ Hits        30420    30435      +15     
+ Misses      12416    12401      -15     
Components Coverage Δ
crashtracker 40.76% <ø> (+0.03%) ⬆️
crashtracker-ffi 8.67% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.95% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.35% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.18% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.14% <ø> (ø)

@danielsn danielsn merged commit b57f46a into main Nov 13, 2024
32 checks passed
@danielsn danielsn deleted the dsn/fix-rfc-link branch November 13, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants