-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize credit_cards_bench inlining #683
Conversation
BenchmarksComparisonBenchmark execution time: 2024-10-21 11:58:01 Comparing candidate commit ebcd997 in PR branch Found 1 performance improvements and 22 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/
scenario:credit_card/is_card_number/37828224631
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて
scenario:redis/obfuscate_redis_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 71.78% 71.80% +0.01%
==========================================
Files 271 271
Lines 40984 40992 +8
==========================================
+ Hits 29422 29434 +12
+ Misses 11562 11558 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
What does this PR do?
Tells the
credit_cards_bench
to not inline theis_credit_card
method to try to stabilize results a bit.Motivation
The results fluctuate due to external factors like dependency changes that seem to affect the benchmarking harness and the inlining decisions.
Additional Notes
The benchmark results will differ from
main
since this PR affects the generated code, but hopefully (and according to my tests), it should stabilize them a bit going forward.