-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-10603] Package libdatadog v13.1.0 for Ruby #674
Conversation
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v13.1.0. **Additional Notes:** We ended up not releasing 13.0 for Ruby. I don't see any reason to backfill so I've skipped ahead. **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3997 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
BenchmarksComparisonBenchmark execution time: 2024-10-14 10:05:52 Comparing candidate commit 80dee15 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taegyunkim approved this PR from Slack with Graphite
What does this PR do?
This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg
Motivation:
Enable Ruby to use libdatadog v13.1.0.
Additional Notes:
We ended up not releasing 13.0 for Ruby. I don't see any reason to backfill so I've skipped ahead.
How to test the change?
I've tested this release locally using the changes in DataDog/dd-trace-rb#3997 .
As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.