refactor(ffe): simplify error handling #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-10-28 20:04:57 Comparing candidate commit 6e39f29 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## sameerank/FFL-1284-Create-datadog-ffe-ffi-crate #1285 +/- ##
===================================================================================
+ Coverage 71.78% 71.79% +0.01%
===================================================================================
Files 372 371 -1
Lines 58251 58237 -14
===================================================================================
+ Hits 41813 41814 +1
+ Misses 16438 16423 -15
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
sameerank
approved these changes
Oct 28, 2025
| }; | ||
| mut context: Handle<EvaluationContext>, | ||
| ) -> Result<Handle<Assignment>> { | ||
| wrap_with_ffi_result!({ |
Contributor
There was a problem hiding this comment.
wrap_with_ffi_result is definitely cleaner and more consistent with the other FFIs!
…fe-simplify-error-handling
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
merged commit c453cb9
into
sameerank/FFL-1284-Create-datadog-ffe-ffi-crate
37 checks passed
dd-mergequeue bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
Add FFI bindings for datadog-ffe Creates C-compatible FFI layer for Feature Flagging & Experimentation: - Add datadog-ffe-ffi crate following ddsketch-ffi patterns - Implement Handle<T> wrappers for Configuration, EvaluationContext, Assignment - Export get_assignment, configuration_new, evaluation_context_new functions - Add memory management with drop functions - Generate C headers via cbindgen for Ruby integration - Update Cargo.toml to include new FFI crate in workspace Fix missing newlines at ends of files Fix Rust formatting issues in datadog-ffe-ffi - Remove trailing whitespace from doc comments - Reformat function call in assignment.rs to fit line length constraints Remove unused NULL_POINTER_ERROR constant from error.rs Fix formatting in assignment.rs by removing trailing whitespace from doc comments Update LICENSE-3rdparty.yml to include datadog-ffe-ffi Add datadog-ffe-ffi Cargo.toml to Dockerfile.build Set datadog-ffe-ffi version to 0.1.0 to match pre-release status Update Cargo.lock Refactor build script and cbindgen configuration - Updated build.rs to use a variable for the header name and improved readability. - Modified cbindgen.toml to reorganize export settings and enforce naming conventions for types and functions. - Added Clippy lints in lib.rs to enhance code quality and prevent common pitfalls. Update CODEOWNERS to include datadog-ffe-ffi and team Update datadog-ffe-ffi/Cargo.toml Pin datadog-ffe to exact version Co-authored-by: Oleksii Shmalko <[email protected]> refactor(ffe): simplify error handling (#1285) refactor(ffe): simplify error handling Merge branch 'sameerank/FFL-1284-Create-datadog-ffe-ffi-crate' into ffe-simplify-error-handling Co-authored-by: sameerank <[email protected]> Replace single-attribute constructor with multi-attribute API Replace ddog_ffe_evaluation_context_new_with_attribute with ddog_ffe_evaluation_context_new_with_attributes that accepts an array of AttributePair structs. Remove unnecessary whitespace in evaluation_context.rs Fix documentation formatting in evaluation_context.rs Fix Cargo.toml Prevent malloc error in drop functions Handle take() errors gracefully in ddog_ffe_configuration_drop and ddog_ffe_assignment_drop to prevent malloc corruption from double-free or use-after-free scenarios. Previously, take() failures would panic and cause "pointer being freed was not allocated" errors. Update drop functions to simplify error handling Refactor EvaluationContext API - Changed the `context` parameter in `ddog_ffe_get_assignment` to be a pointer for consistency. - Removed the single-attribute constructor `ddog_ffe_evaluation_context_new` and updated the multi-attribute constructor's documentation for clarity. Merge branch 'main' into sameerank/FFL-1284-Create-datadog-ffe-ffi-crate [ffe] add pyo3 conversion methods [ffe] Remove unused errors [ffe] step back and remove IntoPyObject types These will be defined in dd-trace-py to better match what Python/OF need. Revert "test(ffe): run sdk tests individually (#1273)" This reverts commit b9c68ca. Test generation in build.rs made tests hard to edit. [ffe] Expose EvaluationFailure This is required to allow tracers return more precise error codes. [ffe] remove support for JSON:API Merge remote-tracking branch 'origin/main' into HEAD [ffe] fix clippy Merge remote-tracking branch 'origin/main' into HEAD Update datadog-ffe-ffi/src/evaluation_context.rs Co-authored-by: Oleksii Shmalko <[email protected]> Lint fix Replace Assignment with ResolutionDetails structure Replace AssignmentValue with C-compatible value representation Add error mapping for ResolutionDetails error handling Lint fixes Clippy fixes refactor(ffe): merge EvaluationError and EvalutionFailure into one type The distinction served us well in Eppo but it's less useful as we're migrating to OpenFeature and it handles these various errors rather similarly. Merge remote-tracking branch 'origin/ffe-pyo3-methods' into HEAD feat: handle non-string attributes feat(ffe): adding accessors for ResolutionDetails feat(ffe): preserve json raw value datadog-ffe-ffi: finish assignment getters add missing license header Merge remote-tracking branch 'origin/main' into HEAD fix tests fix parsing RawValue through TryParse (I think) the way serde_json implements untagged enum parsing is by first parsing into serde_json::Value and then parsing that to one of the variants. This breaks RawValue deserialization because Value does not hold onto original string. This PR makes TryParse work by quickly scanning into RawValue first, and then trying to parse it into target type. If that parsing fails, the RawValue is copied into Box. Merge remote-tracking branch 'origin/main' into HEAD feat: support multiple/number expected flag type Merge remote-tracking branch 'origin/main' into HEAD merge main Merge main@origin Co-authored-by: dd-oleksii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #1282 to demo simplified error handling.