Add support for metric_type gauge_delta #190
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to define "gauge_delta" as new metric_type in jmx.d/conf.yaml. JMXFetch will send the metric as StatsD Count-Type which will be handled as "rate" in DataDog. This allows to do time aggregations like "how many errors we had in last hour".
It might be also possible to use/reuse metric_type counter / count, but I am not sure about breaking semantics. Actually this PR is a POC of how gauge deltas can be implemented, as we really need them.