-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add monotonic_count support #203
Conversation
273aedd
to
93b66d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks!
If there are still some unknowns about how the in-app metric type will behave, please list them here.
Also, we should add some documentation about this new JMXFetch metric type. Do you know where it'd be best to document it? (cc @l0k0ms )
I think we should update the java integration here: https://docs.datadoghq.com/integrations/java/#the-attribute-filter. Just open an issue on the doc github repo or in our trello board for tracking and we will do it. |
93b66d0
to
e60ad49
Compare
Force-pushed after rebasing on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and please open a request for a doc update ;) )
What does this PR do
Adds the ability to jmxfetch to consume "monotonic_counts". This new metric type for jmxfetch is going to be almost identical to the agent checks
monotonic_count
:The only difference with agent checks is that the value will be stored as a
rate
in the backend. Functionality wise this should not have any impact.This will allow jmxfetch to monitor counters that increase over time like the total number of request received by a web server and most importantly store them as counts in Datadog.
Notes
This is based on a POC from @mirkoprescha that you can find here: #190.