Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add monotonic_count support #203

Merged
merged 8 commits into from
Feb 13, 2019
Merged

add monotonic_count support #203

merged 8 commits into from
Feb 13, 2019

Conversation

arbll
Copy link
Member

@arbll arbll commented Dec 13, 2018

What does this PR do

Adds the ability to jmxfetch to consume "monotonic_counts". This new metric type for jmxfetch is going to be almost identical to the agent checks monotonic_count:

Submit the sampled raw value of your counter. Don’t normalize the values to a rate, or calculate the deltas before submitting. If the value of your counter ever decreases between submissions the resulting stored value for that submission is 0
https://docs.datadoghq.com/developers/metrics/counts/

The only difference with agent checks is that the value will be stored as a rate in the backend. Functionality wise this should not have any impact.

This will allow jmxfetch to monitor counters that increase over time like the total number of request received by a web server and most importantly store them as counts in Datadog.

Notes

This is based on a POC from @mirkoprescha that you can find here: #190.

@arbll arbll force-pushed the arbll/count-support branch from 273aedd to 93b66d0 Compare December 13, 2018 16:17
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!

If there are still some unknowns about how the in-app metric type will behave, please list them here.

Also, we should add some documentation about this new JMXFetch metric type. Do you know where it'd be best to document it? (cc @l0k0ms )

@l0k0ms
Copy link

l0k0ms commented Jan 4, 2019

I think we should update the java integration here: https://docs.datadoghq.com/integrations/java/#the-attribute-filter. Just open an issue on the doc github repo or in our trello board for tracking and we will do it.

@truthbk truthbk force-pushed the arbll/count-support branch from 93b66d0 to e60ad49 Compare January 31, 2019 07:27
@truthbk
Copy link
Member

truthbk commented Jan 31, 2019

Force-pushed after rebasing on top of master following the merge of #98, also fixed a couple of stylistic issues.

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

(and please open a request for a doc update ;) )

@arbll arbll merged commit 75ef1bf into master Feb 13, 2019
@arbll arbll deleted the arbll/count-support branch February 13, 2019 16:24
@truthbk truthbk added this to the 0.26.0 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants