Skip to content

Conversation

@jbachorik
Copy link
Collaborator

@jbachorik jbachorik commented Feb 10, 2025

What does this PR do?:
This cleans up the CI workflow definition

Motivation:
We want to have the least number of places to modify when we update the CI jobs - with this change we can reduce them to 3 different jobs (glibc-amd64, glibc-aarch64 and musl-amd64) and make the maintenance much easier.
Also, it makes it easier to set up shared JDK caching, saving time and CPU resources on test reruns.

The anecdotical evidence is ~10 minutes of CI run time before this change vs. ~5 minutes after this change (of course, if we do not spend 5 minutes waiting for ubuntu mirrors ...)

How the JDK caching works
We have a dedicated job which refresh the caches once a day such that they are not expired accidentally.
Also, that job is triggered by changes on 'main' branch to the files defining the used JAVA versions making it 'relatively' easy to bump the update versions regularly.

However, this would work only for the 'main' branch because the caches are per-branch (and there is no way around). Hence, we also run the cache-refresh before the test matrix to prevent cache failures for feature branches/PR. This also means that the first build will not be faster than before - but subsequent rebuilds should benefit from the cached binaries.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-11327

Unsure? Have a question? Request a review!

@github-actions
Copy link

github-actions bot commented Feb 10, 2025

🔧 Report generated by pr-comment-scanbuild

Scan-Build Report

User:runner@fv-az1440-40
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 clean all
Clang Version:Ubuntu clang version 18.1.3 (1ubuntu1)
Date:Tue Feb 11 14:37:16 2025

Bug Summary

Bug TypeQuantityDisplay?
All Bugs6
Logic error
Dereference of null pointer3
Suspicious operation
Bitwise shift1
Unused code
Dead initialization1
Dead nested assignment1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Suspicious operationBitwise shiftvmStructs.cppfind87216
Unused codeDead initializationstackWalker.cppwalkDwarf1601
Unused codeDead nested assignmentvmStructs.cppcheckNativeBinding9771
Logic errorDereference of null pointersafeAccess.hload3318
Logic errorDereference of null pointersymbols_linux.hElfParser12928
Logic errorDereference of null pointerflightRecorder.cppflush15138

@github-actions
Copy link

github-actions bot commented Feb 10, 2025

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Warnings (7)

Style Violations (405)

@jbachorik jbachorik marked this pull request as draft February 10, 2025 17:00
@jbachorik jbachorik force-pushed the jb/cache_jdks branch 5 times, most recently from 7842dcc to f57a61d Compare February 11, 2025 12:21
@jbachorik jbachorik force-pushed the jb/cache_jdks branch 3 times, most recently from 3b72450 to ce91f39 Compare February 11, 2025 13:52
@jbachorik jbachorik marked this pull request as ready for review February 11, 2025 14:01
@jbachorik jbachorik requested a review from MattAlp February 11, 2025 14:32
@jbachorik jbachorik merged commit 679f731 into main Feb 11, 2025
84 checks passed
@github-actions github-actions bot added this to the 1.20.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants