-
Notifications
You must be signed in to change notification settings - Fork 11
Restructure CI workflow and improve JDK caching #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e381eff to
0485250
Compare
|
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
0485250 to
108224f
Compare
7842dcc to
f57a61d
Compare
3b72450 to
ce91f39
Compare
ce91f39 to
b20e40b
Compare
b20e40b to
5e17d7f
Compare
MattAlp
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This cleans up the CI workflow definition
Motivation:
We want to have the least number of places to modify when we update the CI jobs - with this change we can reduce them to 3 different jobs (glibc-amd64, glibc-aarch64 and musl-amd64) and make the maintenance much easier.
Also, it makes it easier to set up shared JDK caching, saving time and CPU resources on test reruns.
The anecdotical evidence is ~10 minutes of CI run time before this change vs. ~5 minutes after this change (of course, if we do not spend 5 minutes waiting for ubuntu mirrors ...)
How the JDK caching works
We have a dedicated job which refresh the caches once a day such that they are not expired accidentally.
Also, that job is triggered by changes on 'main' branch to the files defining the used JAVA versions making it 'relatively' easy to bump the update versions regularly.
However, this would work only for the 'main' branch because the caches are per-branch (and there is no way around). Hence, we also run the cache-refresh before the test matrix to prevent cache failures for feature branches/PR. This also means that the first build will not be faster than before - but subsequent rebuilds should benefit from the cached binaries.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!