[ECOINT-304] Add CockroachDB storage and KV metrics #2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following metrics using their DataDog names: - `storage_wal_fsync_latency` - `rebalancing_replicas_queriespersecond` - `range_merges` - `rebalancing_lease_transfers` - `rebalancing_range_rebalances` See also cockroachdb/docs#19425, where these were added to the CockroachDB docs.
rmloveland
force-pushed
the
20250916-cockroachdb-storage-metrics
branch
from
33425d6 to
ccd2dd5
Compare
|
Hi @estherk15! i noticed you reviewed this previous Cockroach Cloud metrics PR a while ago: Are you the right person to ask for a review on this one? Or do you know who I should ask? Thanks! |
|
hi @dd-dominic I noticed you reviewed #2812 - any chance you could take a peek at this one? |
|
@rmloveland thanks for opening a PR. Please update the changelog with an entry for 2.1.0. The current changelog also needs to be reformatted. Dates should be added to each entry and the order needs to be in descending order - the latest entry (2.1.0) should be first. See this format: https://docs.datadoghq.com/developers/integrations/agent_integration/?tab=buildanoutoftheboxintegration#bumping-an-integration-version |
dd-dominic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the following CockroachDB metrics (related to Storage and KV layers) using their DataDog names:
storage_wal_fsync_latencyrebalancing_replicas_queriespersecondrange_mergesrebalancing_lease_transfersrebalancing_range_rebalancesSee also cockroachdb/docs#19425, where these were added to the CockroachDB docs.
Motivation
Integration of these important KV & storage metrics with DataDog
Review checklist
no-changeloglabel attached