Skip to content

Conversation

@pmw-rp
Copy link
Contributor

@pmw-rp pmw-rp commented Jul 20, 2025

What does this PR do?

This PR brings Redpanda metrics up to date.

Motivation

Completeness, customer demand.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean

Additional Notes

We will follow with a later PR to add supporting dashboards that demonstrate some of these metrics. The focus here is to enable customers to use metrics that are already available in the product.

Comment on lines +3 to +41
## 2.2.0 / 2025-07-15

Metrics update release.

***Added***:

* Added new default metrics groups:
* Security and TLS
* `redpanda.authorization`: +1 metric
* `redpanda.security`: +2 metrics
* `redpanda.tls`: +5 metrics

* Added new additional metrics groups:
* Apache Iceberg integration
* `redpanda.iceberg`: +32 metrics
* Redpanda Transforms and WASM
* `redpanda.transform`: +9 metrics
* `redpanda.wasm`: +4 metrics
* Debug bundles
* `redpanda.debug_bundle`: +4 metrics

* Added new metrics under existing default metrics groups:
* `redpanda.application`: +1 metric
* `redpanda.cluster`: +5 metrics
* `redpanda.rpc`: +2 metrics
* `redpanda.kafka`: +8 metrics
* `redpanda.raft`: +5 metrics
* `redpanda.storage`: +2 metrics

* Added new metrics under existing additional metrics groups:
* `redpanda.cloud`: +27 metrics
* `redpanda.pandaproxy`: +3 metrics
* `redpanda.schemaregistry`: +7 metrics

***Fixed***:

* Typo: `redpanda.schema_registry_latency_seconds` is now `redpanda.schema_registry.latency_seconds`
* Typo: `redpanda_cloud_client_dowload_backoff` is now `cloud.client_download_backoff`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 2.2.0 / 2025-07-15
Metrics update release.
***Added***:
* Added new default metrics groups:
* Security and TLS
* `redpanda.authorization`: +1 metric
* `redpanda.security`: +2 metrics
* `redpanda.tls`: +5 metrics
* Added new additional metrics groups:
* Apache Iceberg integration
* `redpanda.iceberg`: +32 metrics
* Redpanda Transforms and WASM
* `redpanda.transform`: +9 metrics
* `redpanda.wasm`: +4 metrics
* Debug bundles
* `redpanda.debug_bundle`: +4 metrics
* Added new metrics under existing default metrics groups:
* `redpanda.application`: +1 metric
* `redpanda.cluster`: +5 metrics
* `redpanda.rpc`: +2 metrics
* `redpanda.kafka`: +8 metrics
* `redpanda.raft`: +5 metrics
* `redpanda.storage`: +2 metrics
* Added new metrics under existing additional metrics groups:
* `redpanda.cloud`: +27 metrics
* `redpanda.pandaproxy`: +3 metrics
* `redpanda.schemaregistry`: +7 metrics
***Fixed***:
* Typo: `redpanda.schema_registry_latency_seconds` is now `redpanda.schema_registry.latency_seconds`
* Typo: `redpanda_cloud_client_dowload_backoff` is now `cloud.client_download_backoff`
## 2.2.0 / 2025-07-28
***Added***:
* New default metrics groups:
* Security and TLS
* `redpanda.authorization`: +1 metric
* `redpanda.security`: +2 metrics
* `redpanda.tls`: +5 metrics
* New additional metrics groups:
* Apache Iceberg integration
* `redpanda.iceberg`: +32 metrics
* Redpanda Transforms and WASM
* `redpanda.transform`: +9 metrics
* `redpanda.wasm`: +4 metrics
* Debug bundles
* `redpanda.debug_bundle`: +4 metrics
* New metrics under existing default metrics groups:
* `redpanda.application`: +1 metric
* `redpanda.cluster`: +5 metrics
* `redpanda.rpc`: +2 metrics
* `redpanda.kafka`: +8 metrics
* `redpanda.raft`: +5 metrics
* `redpanda.storage`: +2 metrics
* New metrics under existing additional metrics groups:
* `redpanda.cloud`: +27 metrics
* `redpanda.pandaproxy`: +3 metrics
* `redpanda.schemaregistry`: +7 metrics
***Fixed***:
* Typo: `redpanda.schema_registry_latency_seconds` is now `redpanda.schema_registry.latency_seconds`
* Typo: `redpanda_cloud_client_dowload_backoff` is now `cloud.client_download_backoff`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace datadog-agent integration install -t datadog-redpanda==<INTEGRATION_VERSION> with datadog-agent integration install -t datadog-redpanda==2.2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmw-rp I'm not seeing the changes. Since this PR has been closed, you'll need to reopen this PR or open a new PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the redpanda_cloud_client_dowload_backoff typo in the current metadata file (https://github.com/DataDog/integrations-extras/blob/master/redpanda/metadata.csv)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo is in metrics.py, not metadata.csv - so this would have affected the actual metrics produced, not the published "what metrics should you expect".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove metrics, so we'll need to keep the row for redpanda.schema_registry_latency_seconds. In the description for this row, please add "[supported in v2.1.0 and below]". Additionally, for the new row redpanda.schema_registry.latency_seconds, add "[supported in v2.2.0+]" in the description.

Can you confirm no additional metrics were removed with this update? It's difficult to see in the GitHub diff.

@dd-dominic
Copy link
Collaborator

Please also fix validations.

@dd-dominic dd-dominic changed the title Redpanda: v2.2.0 (metrics update) [ECOINT-248] Redpanda: v2.2.0 (metrics update) Jul 21, 2025
@github-actions
Copy link

This pull request has not been updated for more than 21 days. If there are no updates to this PR within 7 days, it will be closed. If you'd like to re-open this PR after it's been closed, you can start from the latest master branch or pull the latest changes into your branch and create a new pull request.

@github-actions github-actions bot added the stale label Aug 11, 2025
@hcoyote
Copy link

hcoyote commented Aug 12, 2025

@pmw-rp has been OOO and should be back in a few days to followup on this, so tagging with an update to un-stale this.

@github-actions github-actions bot removed the stale label Aug 13, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

This pull request has not been updated for more than 21 days. If there are no updates to this PR within 7 days, it will be closed. If you'd like to re-open this PR after it's been closed, you can start from the latest master branch or pull the latest changes into your branch and create a new pull request.

@github-actions github-actions bot added the stale label Sep 9, 2025
@github-actions
Copy link

This pull request was not updated after an additional 7 days of no activity. If you would like to continue work on this PR, please re-open this PR or create a fresh branch off of the latest master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants