Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated tomcat.cache metrics #16650

Merged
merged 1 commit into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tomcat/changelog.d/16650.removed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove deprecated `tomcat.cache` metrics
12 changes: 0 additions & 12 deletions tomcat/datadog_checks/tomcat/data/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,18 +60,6 @@ jmx_metrics:
minTime:
alias: tomcat.servlet.min_time
metric_type: gauge
- include:
# Deprecated metric available in Tomcat 7
# https://github.com/apache/tomcat/blob/7.0.x/java/org/apache/catalina/core/StandardContext.java#L5293-L5297
domain_regex: Catalina|Tomcat
type: Cache
attribute:
accessCount:
alias: tomcat.cache.access_count
metric_type: counter
hitsCounts:
alias: tomcat.cache.hits_count
metric_type: counter
- include:
domain_regex: Catalina|Tomcat
type: StringCache
Expand Down
2 changes: 0 additions & 2 deletions tomcat/metadata.csv
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ tomcat.processing_time,gauge,10,,,The sum of request processing times across all
tomcat.servlet.processing_time,gauge,10,,,The sum of request processing times across all requests to the servlet (in milliseconds) per second.,0,tomcat,servlet proc time,
tomcat.servlet.error_count,gauge,10,error,second,The number of erroneous requests received by the servlet per second.,-1,tomcat,servlet err count,
tomcat.servlet.request_count,gauge,10,request,second,The number of requests received by the servlet per second.,0,tomcat,servlet requests,
tomcat.cache.access_count,gauge,10,get,second,The number of accesses to the cache per second.,0,tomcat,cache accesses,
tomcat.cache.hits_count,gauge,10,hit,second,The number of cache hits per second.,0,tomcat,cache hits,
tomcat.servlet.max_time,gauge,10,millisecond,,The maximum processing time of a request,0,tomcat,servlet max time,
tomcat.servlet.min_time,gauge,10,millisecond,,The minimum processing time of a request,0,tomcat,servlet min time,
tomcat.string_cache.access_count,gauge,10,get,second,The number of accesses to the string cache per second.,0,tomcat,string cache accesses,
Expand Down
Loading