Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert id and source_type for Topology Links #13752

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Assert id and source_type for Topology Links #13752

merged 2 commits into from
Jan 20, 2023

Conversation

AlexandreYang
Copy link
Member

What does this PR do?

Assert id and source_type for Topology Links

Motivation

DataDog/datadog-agent#15184

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@AlexandreYang AlexandreYang requested review from a team as code owners January 20, 2023 13:47
NouhaManai96
NouhaManai96 previously approved these changes Jan 20, 2023
View reviewed changes
pducolin
pducolin previously approved these changes Jan 20, 2023
View reviewed changes
@AlexandreYang
Copy link
Member Author

/azp run PR Changes

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AlexandreYang AlexandreYang dismissed stale reviews from pducolin and NouhaManai96 via d71d415 January 20, 2023 19:57
ken-schneider
ken-schneider approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ken-schneider ken-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreYang AlexandreYang merged commit 4439a80 into master Jan 20, 2023
@AlexandreYang AlexandreYang deleted the alex/snmp_topology_link_id branch January 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ken-schneider ken-schneider ken-schneider approved these changes

@pducolin pducolin pducolin left review comments

@NouhaManai96 NouhaManai96 NouhaManai96 left review comments

Assignees
No one assigned
Labels
changelog/no-changelog integration/snmp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandreYang @pducolin @ken-schneider @NouhaManai96