Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tracing naming scheme #13579

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

djova
Copy link
Contributor

@djova djova commented Dec 23, 2022

What does this PR do?

Follow-up to #13576, update the integrations tracing naming scheme to ensure all integrations appear under a single service, matching the name of the service used for profiling. This enables better linking between APM & profiling data, specifically the "Code Hotspots" feature.

image

Since all integrations are now reporting under a single service, the resource name is updated to refer only to the integration name in order to enable us to differentiate reporting from the different integrations. They are all visible in the resource list:

image

Motivation

Improve the tracing & profiling experience for python integrations.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ghost ghost added the base_package label Dec 23, 2022
@djova djova changed the title Djova/update integration tracing naming scheme update integration tracing naming scheme Dec 23, 2022
@djova djova force-pushed the djova/update-integration-tracing-naming-scheme branch from fb1de25 to bb86fc5 Compare December 23, 2022 22:23
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #13579 (86d46e2) into master (cb26679) will increase coverage by 0.23%.
The diff coverage is 82.35%.

Flag Coverage Δ
activemq_xml 82.31% <ø> (ø)
aerospike 87.17% <ø> (+0.32%) ⬆️
airflow 90.00% <ø> (ø)
amazon_msk 88.67% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.43% <ø> (ø)
avi_vantage 92.50% <ø> (ø)
azure_iot_edge 82.00% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 83.33% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.02% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
clickhouse 95.31% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cloudera 99.08% <ø> (ø)
cockroachdb 90.96% <ø> (ø)
consul 91.64% <ø> (ø)
coredns 94.54% <ø> (ø)
couch 95.19% <ø> (+0.24%) ⬆️
couchbase 83.58% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.45% <76.47%> (+0.38%) ⬆️
datadog_checks_dev 82.24% <ø> (+0.07%) ⬆️
datadog_checks_downloader 78.64% <ø> (+0.99%) ⬆️
datadog_cluster_agent 90.00% <ø> (ø)
ddev 98.63% <ø> (ø)
directory 96.50% <ø> (ø)
disk 91.69% <ø> (ø)
dns_check 93.90% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 80.05% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 91.61% <ø> (ø)
envoy 94.23% <ø> (ø)
etcd 93.96% <ø> (ø)
exchange_server 96.85% <ø> (+11.81%) ⬆️
external_dns 89.09% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 83.88% <ø> (ø)
gearmand 78.26% <ø> (+1.24%) ⬆️
gitlab_runner 91.94% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
go_expvar 92.73% <ø> (ø)
gunicorn 92.85% <ø> (ø)
haproxy 95.12% <ø> (+0.16%) ⬆️
harbor 80.04% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
http_check 95.38% <ø> (+2.08%) ⬆️
ibm_ace 91.79% <ø> (ø)
ibm_db2 95.10% <ø> (ø)
ibm_i 81.95% <ø> (ø)
ibm_mq 91.37% <ø> (ø)
ibm_was 96.08% <ø> (ø)
iis 94.61% <ø> (+38.78%) ⬆️
impala 97.97% <ø> (ø)
istio 77.65% <ø> (+0.55%) ⬆️
kafka_consumer 84.06% <ø> (ø)
kong 87.56% <ø> (ø)
kube_apiserver_metrics 97.69% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.96% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.30% <ø> (-0.47%) ⬇️
marathon 83.12% <ø> (ø)
marklogic 96.03% <ø> (ø)
mcache 93.26% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
mongo 96.51% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.92% <ø> (+0.95%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx 95.24% <ø> (+0.54%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 90.93% <ø> (ø)
oracle 90.24% <ø> (ø)
pdh_check 95.65% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
rabbitmq 94.41% <ø> (ø)
redisdb 87.50% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 91.64% <ø> (ø)
scylla 100.00% <ø> (ø)
silk 93.33% <ø> (ø)
singlestore 90.81% <ø> (ø)
snmp 85.49% <ø> (+0.04%) ⬆️
snowflake 96.47% <ø> (ø)
sonarqube 98.21% <ø> (ø)
spark 93.57% <ø> (-0.29%) ⬇️
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.30% <ø> (ø)
system_core 90.90% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teamcity 88.35% <ø> (+2.87%) ⬆️
teradata 94.24% <ø> (ø)
tls 91.82% <ø> (+0.84%) ⬆️
tokumx 58.40% <ø> (?)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
vault 95.53% <ø> (+0.57%) ⬆️
vertica 98.50% <ø> (ø)
voltdb 96.84% <ø> (ø)
vsphere 89.91% <ø> (+0.08%) ⬆️
win32_event_log 86.40% <ø> (+0.27%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 89.14% <ø> (ø)
zk 86.63% <ø> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@djova djova mentioned this pull request Dec 27, 2022
5 tasks
@djova djova force-pushed the djova/update-integration-tracing-naming-scheme branch 2 times, most recently from 798b697 to 468cbd9 Compare December 27, 2022 19:36
@djova djova marked this pull request as ready for review December 27, 2022 19:48
@djova djova requested review from a team as code owners December 27, 2022 19:48
@djova djova requested a review from coignetp December 27, 2022 19:52
@djova djova force-pushed the djova/update-integration-tracing-naming-scheme branch from 2c92e8c to 5e1322d Compare December 27, 2022 19:54
Follow-up to #13576, update the integrations tracing naming scheme to ensure all integrations appear under a single service, matching the name of the service used for profiling. This enables better linking between APM & profiling data, specifically the "Code Hotspots" feature.

Since all integrations are now reporting under a single service, the resource name is updated to refer only to the integration name in order to enable us to differentiate reporting from the different integrations. They are all visible in the resource list for that one common service.
@djova djova force-pushed the djova/update-integration-tracing-naming-scheme branch from 5e1322d to 682e2ae Compare December 27, 2022 19:57
@ofek ofek changed the title update integration tracing naming scheme Update integration tracing naming scheme Dec 28, 2022
@djova djova merged commit a466a27 into master Dec 28, 2022
@djova djova deleted the djova/update-integration-tracing-naming-scheme branch December 28, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants