Exclude agent pod from admission controller library injection #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanny-jiang
changed the title
fanny-jiang
added
the
chart/datadog
fanny-jiang
changed the title
fanny-jiang
changed the title
clamoriniere
approved these changes
Feb 1, 2024
|
@fanny-jiang the CI job seems to fail on the Daemonset labels |
clamoriniere
reviewed
Feb 1, 2024
Co-authored-by: Cedric Lamoriniere <[email protected]>
clamoriniere
requested changes
Feb 1, 2024
clamoriniere
approved these changes
Feb 1, 2024
|
Did we add the label in the right place? For the label to be applied to the pods managed by the deployments/daemonset, it needs to be under |
|
I have created this PR that should set the label on pods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Exclude the agent pod from library injection (receiving new environment variables) when the admission controller is enabled. The agent doesn't send traces and it can be configured to send dogstatsd metrics so it is unnecessary to perform library injection on the agent pod.
This change will also prevent daemonset/agent pod creation problems in GKE Autopilot, which does not allow privileged pod to be mutated.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)