Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Use datadog.fullname to parametrize KPI configmap #1294

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

liliyadd
Copy link
Contributor

What this PR does / why we need it:

BUG FIX

Use {{ template "datadog.fullname" . }} instead of {{ .Release.Name }} to parametrize the Configmap name

Which issue this PR fixes

#1293

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@liliyadd liliyadd requested a review from a team as a code owner January 16, 2024 16:38
@liliyadd liliyadd requested a review from CharlyF January 16, 2024 16:38
Copy link
Contributor

@CharlyF CharlyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rendered:

# Source: datadog/templates/kpi-telemetry-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: orchexplorerdefault-datadog-kpi-telemetry-configmap
  namespace: default
  labels:
    helm.sh/chart: 'datadog-3.51.1'
    app.kubernetes.io/name: "orchexplorerdefault-datadog"
    app.kubernetes.io/instance: "orchexplorerdefault"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: "7"
data:
  install_id: "62413100-xxx"
  install_type: k8s_manual
  install_time: "1705425730"

@CharlyF CharlyF merged commit cb13eed into main Jan 16, 2024
14 checks passed
@CharlyF CharlyF deleted the liliya.belaus/helm-kpi-configmap-fix branch January 16, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants