Add options for force delete monitors #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmuesch
reviewed
Jan 13, 2020
| # Cop supports --auto-correct. | ||
| Layout/EmptyLineAfterMagicComment: | ||
| Exclude: | ||
| - 'dogapi.gemspec' | ||
| - 'spec/integration/comment_spec.rb' |
There was a problem hiding this comment.
Are these no longer needed?
There was a problem hiding this comment.
ran the rubocop autogenerate command rubocop --auto-gen-config with the ruby version that's used for linting so I think this should be good
nmuesch
reviewed
Jan 13, 2020
| @@ -549,8 +549,8 @@ def can_delete_monitors(monitor_ids) | |||
| @monitor_svc.can_delete_monitors(monitor_ids) | |||
| end | |||
|
|
|||
| def delete_monitor(monitor_id) | |||
| @monitor_svc.delete_monitor(monitor_id) | |||
| def delete_monitor(monitor_id, options = {}) | |||
There was a problem hiding this comment.
This means existing users that aren't passing in options will still be able to omit it, right? I.e. we're backwards compatible here?
There was a problem hiding this comment.
Yeah, there's a default argument so it's backwards compatible!
nmuesch
reviewed
Jan 13, 2020
| @@ -51,6 +51,17 @@ | |||
| :delete, "/monitor/#{MONITOR_ID}" | |||
| end | |||
|
|
|||
| describe '#delete_monitor with options' do | |||
nmuesch
approved these changes
Jan 14, 2020
zippolyte
changed the title
zippolyte
added
the
changelog/Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/MA-791
What does this PR do?
Allow monitors to be force deleted even if part of composite or SLO via options
Description of the Change
Enabled options to be passed in the
monitor_deletefunction in the client, to allow for force deletion.Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.