Skip to content

Conversation

@OliviaShoup
Copy link
Contributor

What does this PR do? What is the motivation?

This PR document input parameters for App Builder in a new subpage of Embedded Apps.

Merge instructions

Merge readiness:

  • Ready for merge

@OliviaShoup OliviaShoup added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 8, 2025
@OliviaShoup OliviaShoup requested a review from a team as a code owner December 8, 2025 18:00
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Comment on lines 42 to 50
1. In [App Builder][1], select an app with a configured input parameter(s).
1. Click the settings icon ({{< img src="icons/settings.png" inline="true" style="width:14px;">}}).
1. Click **Add to a dashboard**.
1. Select a dashboard, then click **Save and Open**.
1. In your dashboard, click the **Edit** icon ({{< img src="icons/pencil.png" inline="true" style="width:14px;">}}).
1. In the **Input Parameters** section, select an input parameter.
1. Click **Save**.
1. Duplicate the app with copy + paste keyboard shortcuts, or clone it.
1. Follow the steps above to select a different input parameter.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be helpful to explain more in depth how to update the input parameter from a dashboard.

either another subsection ("How to change an input parameter from a dashboard") or a screenshot would be helpful IMO!

Comment on lines 49 to 50
1. Duplicate the app with copy + paste keyboard shortcuts, or clone it.
1. Follow the steps above to select a different input parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these last two steps should be a separate procedure. Add a sentence at the beginning explaining what you're about to do, then restart the step numbering at 1.

My reasoning is that in the introduction to the procedure, you say that the instructions "embed an app with input parameters." To me, that means one app. I think it's reasonable to include the instructions for the second, customized app, but the steps need some separation.


To embed an app with input parameters:

1. In [App Builder][1], select an app with a configured input parameter(s).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. In [App Builder][1], select an app with a configured input parameter(s).
1. In [App Builder][1], select an app with a configured input parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend Images Images are added/removed with this PR WORK IN PROGRESS No review needed, it's a wip ;)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants