Skip to content

Conversation

@git-thuerk-done
Copy link
Contributor

@git-thuerk-done git-thuerk-done commented Dec 2, 2025

What does this PR do? What is the motivation?

Adds a glossary to the CNM docs

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@git-thuerk-done git-thuerk-done requested a review from a team as a code owner December 2, 2025 16:45
@git-thuerk-done git-thuerk-done added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 2, 2025
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

@git-thuerk-done git-thuerk-done removed the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 3, 2025
@cswatt cswatt added the editorial review Waiting on a more in-depth review label Dec 3, 2025
@cswatt
Copy link
Contributor

cswatt commented Dec 3, 2025

Added DOCS-12826 for editorial review.

@@ -0,0 +1,77 @@
---
Copy link
Member

@AlexandreYang AlexandreYang Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either have either

1/ one glossary page per product CNM, Network Path, NDM

or 2/ a single glossary for all network product, but then, we need to move the glossary at the Network Monitoring level.

What do you think?

I'm learning toward 1/ , but 2/ would work too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good callout, I thought about that too, I think Network Path should have it's own glossary so I'll move the Network path section there, thank you!

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion and a question. Otherwise, looks great! Approving, but let me know if you would like anything re-reviewed.

@git-thuerk-done git-thuerk-done merged commit 7b91ba2 into master Dec 8, 2025
16 checks passed
@git-thuerk-done git-thuerk-done deleted the aliciathuerk/DOCS-12675-CNM-glossary branch December 8, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants