Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-3013 - automatic semantic color tag keys #17430

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Conversation

davidejones
Copy link
Member

@davidejones davidejones commented Mar 27, 2023

What does this PR do?

This PR:

  • pulls in semantic color tag keys docs from web-ui
  • updates script to provide alternative base path to content dir

Motivation

https://datadoghq.atlassian.net/browse/WEB-3013

Preview

https://docs-staging.datadoghq.com/david.jones/web-3013/dashboards/guide/semantic_colors/

Additional Notes


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@github-actions github-actions bot added Architecture Everything related to the Doc backend Guide Content impacting a guide labels Mar 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@davidejones davidejones force-pushed the david.jones/web-3013 branch 3 times, most recently from 4bd0a06 to 37f1030 Compare March 28, 2023 10:24
@davidejones davidejones force-pushed the david.jones/web-3013 branch from 37f1030 to 9299b3e Compare April 4, 2023 11:53
@@ -0,0 +1,2 @@
| Tag key | Description |
| :---------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file exists so that local build doesn't throw errors, it will get replaced with the real table during the ci/cd

@davidejones davidejones force-pushed the david.jones/web-3013 branch from 9299b3e to abecc4c Compare April 17, 2023 12:38
@davidejones davidejones force-pushed the david.jones/web-3013 branch from abecc4c to 6b42bf4 Compare April 18, 2023 12:05
@davidejones davidejones marked this pull request as ready for review April 18, 2023 12:06
@davidejones davidejones requested review from a team as code owners April 18, 2023 12:06
@estherk15
Copy link
Contributor

@davidejones I can merge for docs if this is ready

@davidejones
Copy link
Member Author

Good to merge here @estherk15 👍

@estherk15 estherk15 merged commit 43ce49d into master Apr 18, 2023
@estherk15 estherk15 deleted the david.jones/web-3013 branch April 18, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants