Update Session User and RUM Global Context APIs #15013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
real_user_monitoring
4 tasks
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Aug 17, 2022
| To identify user sessions, use the `setUser` API: | ||
| When making changes to the user session object, all RUM events collected afterwards the change contain the updated information. | ||
| ## User session APIs |
Contributor
There was a problem hiding this comment.
💬 suggestion: what about having a sub section for each capability (like global context)?
something like:
## user sessions
### identify user session
### access user session
### override user session property
### clear user session
Contributor
There was a problem hiding this comment.
it could be nice to merge
## Identify user sessions
## User session APIs
### Identify user sessions
into
## User session
### Identify user sessions
it avoid to duplicate the "identify user sessions" header and regroup all things related to user session in a single section, like Global Context
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Bastien Caudan <[email protected]>
…text.md Co-authored-by: Bastien Caudan <[email protected]>
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Heston Hoffman <[email protected]>
…text.md Co-authored-by: Bastien Caudan <[email protected]>
liywjl
commented
Aug 17, 2022
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
bcaudan
approved these changes
Aug 23, 2022
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/modifying_data_and_context.md
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Aug 23, 2022
…text.md Co-authored-by: Bastien Caudan <[email protected]>
…text.md Co-authored-by: Bastien Caudan <[email protected]>
liywjl
commented
Aug 23, 2022
Contributor
Author
|
closing in favour of #15085 (due to bad branch name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
We have expanded the API behaviour of Session User APIs and used this as an occasion to fix some of the issues present in the underlying code. We expanded the changes to also to fix similar issues in RUM Global Context.
Additional Notes
Reviewer checklist