Dev: fix quoting in rake command #5177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-12-19 22:53:56 Comparing candidate commit 80b4e07 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:profiling - intern mixed existing and new
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 80b4e07 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
vpellan
approved these changes
Dec 22, 2025
p-datadog
pushed a commit
that referenced
this pull request
Dec 22, 2025
* worker-shutdown-race: standard standard exclude JRuby 10 JIT threads from thread leaker reporting Exclude JRuby file descriptors from leak reporting DEBUG-4548 Fix global state dependency in crashtracking and process discovery tests (#5175) fix quoting in rake command (#5177) Update system tests (incl. `bin/rails` fix for 2.6) Update system tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes quoting in the rake command
Motivation:
[ and ] are special characters in the shell, zsh by default does not interpret them verbatim and uses them to glob. The result is that printed command cannot be pasted directly into zsh.
Change log entry
None
Additional Notes:
There is existing quoting for the space between arguments which is doubly annoying - those quotes have to be deleted when pasting the command into zsh since they interfere with the quoting around [ and ] (or the brackets have to be individually quoted, which requires adding 4 quotes total).
How to test the change?
Existing CI