-
Notifications
You must be signed in to change notification settings - Fork 398
Fix APISecurity::RouteExtractor for Rails 8.1.1+ #5042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rails 8.1.1 removes the `action_dispatch.route_uri_pattern` from `request.env` and replaces it with `action_dispatch.route`: rails/rails@6fd05c9
BenchmarksBenchmark execution time: 2025-11-12 17:02:36 Comparing candidate commit a693370 in PR branch Found 2 performance improvements and 5 performance regressions! Performance is the same for 37 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:line instrumentation - untargeted
scenario:method instrumentation
scenario:profiling - Allocations (baseline)
scenario:tracing - Propagation - Datadog
scenario:tracing - Propagation - Trace Context
scenario:tracing - Tracing.log_correlation
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: a693370 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care 🤗
What does this PR do?
This PR:
rescuetoAPISecurity::RouteExtractor.route_patternwith telemetry error reportingAPISecurity::SamplerMotivation:
#5040
Rails 8.1.1 removes the
action_dispatch.route_uri_patternfromrequest.envand replaces it withaction_dispatch.route:rails/rails@6fd05c9
Change log entry
Yes. AppSec: Fix route extraction error for Rails 8.1.1+.
Additional Notes:
None.
How to test the change?
CI and manual testing.