-
Notifications
You must be signed in to change notification settings - Fork 398
feat: add process tags to traces #5033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… This is still missing memoization and additional tests.
|
Thank you for updating Change log entry section 👏 Visited at: 2025-12-02 20:18:02 UTC |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 50d3392 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
…he payload has the process tag only when the feature is enabled.
…versions so this fixes that.
Co-authored-by: Marco Costa <[email protected]>
BenchmarksBenchmark execution time: 2025-12-04 03:26:05 Comparing candidate commit 50d3392 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:error - error tracking, with_error=true - third_party only
scenario:tracing - Propagation - Trace Context
|
Typing analysisNote: Ignored files are excluded from the next sections. Untyped methodsThis PR introduces 2 partially typed methods. It increases the percentage of typed methods from 55.46% to 55.53% (+0.07%). Partially typed methods (+2-0)❌ Introduced:If you believe a method or an attribute is rightfully untyped or partially typed, you can add |
…uby conflict with sqlite and it is not needed for this test
|
This one is even more of a pickle: |
Co-authored-by: Oleg Pudeyev <[email protected]>
Co-authored-by: Oleg Pudeyev <[email protected]>
… need to add the additional process values normalization logic for service names since they can only be 100 characters and cannot have colons.
p-datadog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit changing before/after to around for the $0 override.
Co-authored-by: Oleg Pudeyev <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
marcotc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend applying the renamming suggested by @Strech in 5cae372#r2584467486, but all else is good!
… tests for the singular version of MAX_PROCESS_VALUE_BYTE_SIZE
* master: (523 commits) DI: relax upper bound for reported long method duration (#5113) Change development guide to use Ruby 3.4 by default (#5112) Fix exception in RC on OpenFeature::Engine absence [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/19996135509 [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/19996155319 Add ruby guikld to all dsm files add DSM to codeowners feat: add process tags to traces (#5033) DEBUG-3558 DI: chunk snapshot payloads (#5086) CI: enable push_to_test_optimization unless this is a pull request from a fork fix steep checks [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/19827679824 [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/19827296218 Add test to verify consumer backlog serialization with kafka_commit tag Remove one diagnostic output Install rubygems Add diagnostic steps Use default rubygems+bundler for each Ruby version Revert "Disable profiling specs for 4.0" Use git `datadog-ruby_core_source` having 4.0 ...
What does this PR do?
The goal of AIDM-253 is to add process tags to the trace payloads.
After this gets merged, the next step is to add it for the other products.
To run the tests in docker
Main tests:
Motivation:
We're trying to add process tags to various payloads so they can be used in different use cases.
Note I still want to try adding server type but I'll have to tackle that in a separate PR.
Change log entry
Yes. Adds process tags to trace payloads with the new environment variable:
DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED.Additional Notes:
How to test the change?