Add DSM Integration to the Waterdrop instrumentation#5031
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-11-14 19:59:42 UTC |
Typing analysisThis PR does not change typing compared to the base branch. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 604731a | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-11-17 15:57:53 Comparing candidate commit 604731a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
dfadb4d to
5010aef
Compare
Strech
left a comment
There was a problem hiding this comment.
I left a question about the footprint in case we don't have data streams activated.
P.S Please fill in the PR template
5010aef to
604731a
Compare
vpellan
left a comment
There was a problem hiding this comment.
LGTM! (with a non blocker comment)
This is one commit on top of the Waterdrop PR (here: #4874) to add DSM to the Waterdrop instrumentation
What does this PR do?
This PR adds DSM instrumentation to Waterdrop ensuring that if DSM is enabled and they use the Karafka ecosystem, a customer can have DSM through their architecture
Motivation:
Adding DSM to Ruby and all design partners use Waterdrop
Change log entry
Yes. Waterdrop producers are compatible with Data Streams Monitoring (DSM)
Additional Notes:
How to test the change?