Skip to content

Add DSM Integration to the Waterdrop instrumentation#5031

Merged
ericfirth merged 1 commit intomasterfrom
eric.firth/add-waterdrop-dsm-integration
Nov 17, 2025
Merged

Add DSM Integration to the Waterdrop instrumentation#5031
ericfirth merged 1 commit intomasterfrom
eric.firth/add-waterdrop-dsm-integration

Conversation

@ericfirth
Copy link
Contributor

@ericfirth ericfirth commented Nov 7, 2025

This is one commit on top of the Waterdrop PR (here: #4874) to add DSM to the Waterdrop instrumentation

What does this PR do?
This PR adds DSM instrumentation to Waterdrop ensuring that if DSM is enabled and they use the Karafka ecosystem, a customer can have DSM through their architecture

Motivation:
Adding DSM to Ruby and all design partners use Waterdrop

Change log entry

Yes. Waterdrop producers are compatible with Data Streams Monitoring (DSM)

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-11-14 19:59:42 UTC

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Typing analysis

This PR does not change typing compared to the base branch.

@datadog-official
Copy link

datadog-official bot commented Nov 7, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 91.49%
Total Coverage: 98.36% (-0.11%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 604731a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025

Benchmarks

Benchmark execution time: 2025-11-17 15:57:53

Comparing candidate commit 604731a in PR branch eric.firth/add-waterdrop-dsm-integration with baseline commit 49cee89 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@ericfirth ericfirth force-pushed the eric.firth/add-waterdrop-dsm-integration branch 3 times, most recently from dfadb4d to 5010aef Compare November 13, 2025 20:35
@ericfirth ericfirth marked this pull request as ready for review November 13, 2025 20:35
@ericfirth ericfirth requested review from a team as code owners November 13, 2025 20:35
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question about the footprint in case we don't have data streams activated.

P.S Please fill in the PR template

@ericfirth ericfirth force-pushed the eric.firth/add-waterdrop-dsm-integration branch from 5010aef to 604731a Compare November 17, 2025 15:06
Copy link
Contributor

@vpellan vpellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (with a non blocker comment)

@ericfirth ericfirth merged commit f33bab7 into master Nov 17, 2025
553 of 554 checks passed
@ericfirth ericfirth deleted the eric.firth/add-waterdrop-dsm-integration branch November 17, 2025 17:53
@github-actions github-actions bot added this to the 2.23.0 milestone Nov 17, 2025
@Strech Strech mentioned this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants