-
Notifications
You must be signed in to change notification settings - Fork 398
Add check for CGNAT IP range when checking for private IPs #4975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nowadays this IP range is used more and more for kubernetes pods.
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 841. Ignored filesNote: Ignored files are excluded from the next sections.
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 63c8c6f | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-10-13 15:57:16 Comparing candidate commit 63c8c6f in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:profiling - Allocations (baseline)
scenario:profiling - profiler gc
|
What does this PR do?
This PR changes private IP detection to also treat IPs from
100.54.0.0/10range as private.Motivation:
This should improve accuracy of remote IP detection. Nowadays this IP range is used more and more for kubernetes pods.
Change log entry
Yes. Tracing: Treat IPs from
100.65.0.0/10IP range as private.Additional Notes:
APPSEC-58079
How to test the change?
CI and system tests.