Fix handling of AppSec actions passed with Remote Config #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4497 +/- ##
==========================================
- Coverage 97.69% 97.69% -0.01%
==========================================
Files 1381 1381
Lines 83954 83974 +20
Branches 4253 4255 +2
==========================================
+ Hits 82021 82040 +19
- Misses 1933 1934 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20636 Passed, 1370 Skipped, 3m 24.07s Total Time |
BenchmarksBenchmark execution time: 2025-03-14 14:07:07 Comparing candidate commit a9165af in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes parsing of actions that were passed via Remote Config for
ASMproduct.Motivation:
Custom configuration for blocking response done in Datadog UI was not parsed by our library.
Change log entry
Yes. AppSec: Fixed: Custom In-App WAF blocking response that was configured in the UI is now applied correctly.
Additional Notes:
None.
How to test the change?
CI and manual testing with app generator.