Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Bump minimum libddwaf version to include mem-leak fix #4422

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Feb 21, 2025

What does this PR do?

Bump min libddwaf version to include mem-leak fix.

Motivation:

In the upcoming 2.11 release it will be good to have the fixed version of libddwaf by default.

Change log entry

Yes. AppSec: Fix memory leak in libddwaf library which might appear for RASP calls.

Additional Notes:

None.

How to test the change?

It will be tested in underlying library, but here is a real-env screenshot

Screenshot 2025-02-21 at 10 13 09

@Strech Strech requested a review from a team as a code owner February 21, 2025 09:13
@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-21 10:31:31

Comparing candidate commit 64ac857 in PR branch bump-libddwaf-version with baseline commit 29a6bd8 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+3230.618op/s; +3308.003op/s] or [+10.858%; +11.118%]

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 21, 2025

Datadog Report

Branch report: bump-libddwaf-version
Commit report: 64ac857
Test service: dd-trace-rb

✅ 0 Failed, 20606 Passed, 1371 Skipped, 3m 10.68s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (29a6bd8) to head (64ac857).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4422   +/-   ##
=======================================
  Coverage   97.72%   97.73%           
=======================================
  Files        1365     1365           
  Lines       83337    83337           
  Branches     4219     4219           
=======================================
+ Hits        81440    81446    +6     
+ Misses       1897     1891    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Strech Strech added the appsec Application Security monitoring product label Feb 21, 2025
@Strech Strech enabled auto-merge February 21, 2025 11:14
@Strech Strech changed the title Bump minimum libddwaf version to include mem-leak fix [NO-TICKET] Bump minimum libddwaf version to include mem-leak fix Feb 21, 2025
@Strech Strech merged commit a067f81 into master Feb 21, 2025
510 of 511 checks passed
@Strech Strech deleted the bump-libddwaf-version branch February 21, 2025 11:17
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants