-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add excon instrumentation for AppSec #4399
Conversation
BenchmarksBenchmark execution time: 2025-02-18 17:06:26 Comparing candidate commit 7b6d2c9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 33 metrics, 2 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4399 +/- ##
==========================================
- Coverage 97.71% 97.69% -0.03%
==========================================
Files 1361 1366 +5
Lines 83241 83372 +131
Branches 4227 4230 +3
==========================================
+ Hits 81339 81450 +111
- Misses 1902 1922 +20 ☔ View full report in Codecov by Sentry. |
Datadog ReportBranch report: ✅ 0 Failed, 20768 Passed, 1372 Skipped, 3m 13.47s Total Time |
db5dbf0
to
1c3d617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 minor comments, well done 👏🏼
b44ad1b
to
7b6d2c9
Compare
What does this PR do?
This PR adds SSRF detection to
excon
http client library.To enable
excon
instrumentation:Motivation:
We want to enable SSRF detection for most popular ruby http client libraries.
Change log entry
Yes. AppSec: Add detection of Server-Side Request Forgery attacks for
excon
http client.Additional Notes:
Auto-patching for
excon
is set to false, since it might be used as an adapter forfaraday
http client, which has auto-patching enabled.How to test the change?
CI and app-generator (
rails-ssrf
application)