-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faraday instrumentation for AppSec #4391
Conversation
BenchmarksBenchmark execution time: 2025-02-18 09:54:45 Comparing candidate commit 0158995 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
Datadog ReportBranch report: ✅ 0 Failed, 20398 Passed, 1373 Skipped, 3m 12.28s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4391 +/- ##
==========================================
- Coverage 97.71% 97.71% -0.01%
==========================================
Files 1354 1361 +7
Lines 83085 83246 +161
Branches 4219 4226 +7
==========================================
+ Hits 81188 81341 +153
- Misses 1897 1905 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see that we have a solid ground to develop integrations. I left a few comments over naming and testing because I think we could do better and simplify even more
b36bc90
to
22b7115
Compare
b7fbdd1
to
6de7666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👏🏼
I have a few non-blocking suggestions, but for tests it's an important.
What does this PR do?
This PR adds Faraday instrumentation to AppSec for Server-Side Request Forgery detection.
Motivation:
We want to detect SSRF attacks on applications using Faraday as the http client. Support for more http clients (
excon
andrest-client
) will be added in subsequent PRs.Change log entry
Yes. AppSec: Add detection of Server-Side Request Forgery attacks for Faraday http client.
Additional Notes:
Patcher is heavily inspired by our Tracing Faraday patcher.
How to test the change?
CI and manual testing with app-generator (
rails-ssrf
variant)