Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3457 start DI probe notifier worker on every event submission #4363

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

p-datadog
Copy link
Member

What does this PR do?
Alternative implementation to #4358, this PR checks if the probe notifier worker is running on every event submission and starts it if the process forked.

Motivation:
DI is not submitting events to backend in some forked server configurations.

Change log entry
Yes: fix dynamic instrumentation event submission on forked servers

Additional Notes:

How to test the change?
Tested manually against debugger-demo-ruby

@p-datadog p-datadog requested a review from a team as a code owner February 10, 2025 23:42
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: di-worker-2
Commit report: b0e9005
Test service: dd-trace-rb

✅ 0 Failed, 22072 Passed, 1477 Skipped, 5m 47.77s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (5319afc) to head (b0e9005).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
+ Coverage   97.73%   97.74%   +0.01%     
==========================================
  Files        1348     1348              
  Lines       82508    82511       +3     
  Branches     4199     4199              
==========================================
+ Hits        80636    80650      +14     
+ Misses       1872     1861      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-11 00:04:44

Comparing candidate commit b0e9005 in PR branch di-worker-2 with baseline commit 5319afc in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - 10 span trace - no writer

  • 🟩 throughput [+148.811op/s; +152.976op/s] or [+5.366%; +5.516%]

scenario:tracing - 100 span trace - no writer

  • 🟩 throughput [+19.964op/s; +20.808op/s] or [+6.024%; +6.278%]

@p-datadog p-datadog merged commit 6021b3d into master Feb 11, 2025
498 of 499 checks passed
@p-datadog p-datadog deleted the di-worker-2 branch February 11, 2025 14:03
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants