-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APPSEC-56683] Add appsec.auto_user_instrumentation.mode
setting
#4352
[APPSEC-56683] Add appsec.auto_user_instrumentation.mode
setting
#4352
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 22090 Passed, 1477 Skipped, 5m 43.45s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4352 +/- ##
==========================================
- Coverage 97.73% 97.73% -0.01%
==========================================
Files 1348 1351 +3
Lines 82511 82681 +170
Branches 4199 4197 -2
==========================================
+ Hits 80646 80810 +164
- Misses 1865 1871 +6 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-11 10:23:21 Comparing candidate commit 18e933f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - sample timeline=false
|
1b6e5a2
to
6d78f43
Compare
* Add devise mock user support class
6d78f43
to
000b225
Compare
000b225
to
cb0e9ad
Compare
…ion-mode-configuration
What does this PR do?
Adds a new customer-facing setting for AppSec which is suppose to replace existing deprecated option. It will not take precedence over existing setting, but since new and old settings is an explicit opt-out, as soon as any of them set to
disabled
, the feature will be disabled.Motivation:
This is a part of the automated user tracking functionality.
Change log entry
Yes. AppSec: Deprecate
appsec.track_user_events
configuration setting in favor ofappsec.auto_user_instrumentation
.Additional Notes:
This setting immediately will be incorporated into existing code, so it will be fine to release it without an additional functionality.
How to test the change?
CI should be enough