Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-56683] Add appsec.auto_user_instrumentation.mode setting #4352

Merged

Conversation

Strech
Copy link
Member

@Strech Strech commented Feb 6, 2025

What does this PR do?

Adds a new customer-facing setting for AppSec which is suppose to replace existing deprecated option. It will not take precedence over existing setting, but since new and old settings is an explicit opt-out, as soon as any of them set to disabled, the feature will be disabled.

Motivation:

This is a part of the automated user tracking functionality.

Change log entry

Yes. AppSec: Deprecate appsec.track_user_events configuration setting in favor of appsec.auto_user_instrumentation.

Additional Notes:

This setting immediately will be incorporated into existing code, so it will be fine to release it without an additional functionality.

How to test the change?

CI should be enough

@github-actions github-actions bot added the appsec Application Security monitoring product label Feb 6, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: appsec-56683-update-auto-user-instrumentation-mode-configuration
Commit report: 18e933f
Test service: dd-trace-rb

✅ 0 Failed, 22090 Passed, 1477 Skipped, 5m 43.45s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 99.58848% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.73%. Comparing base (5c1cea4) to head (18e933f).

Files with missing lines Patch % Lines
lib/datadog/appsec/contrib/devise/configuration.rb 92.85% 1 Missing ⚠️
...ec/contrib/devise/patcher/authenticatable_patch.rb 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4352      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files        1348     1351       +3     
  Lines       82511    82681     +170     
  Branches     4199     4197       -2     
==========================================
+ Hits        80646    80810     +164     
- Misses       1865     1871       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-11 10:23:21

Comparing candidate commit 18e933f in PR branch appsec-56683-update-auto-user-instrumentation-mode-configuration with baseline commit 5c1cea4 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.512op/s; +0.524op/s] or [+8.721%; +8.929%]

@Strech Strech force-pushed the appsec-56683-update-auto-user-instrumentation-mode-configuration branch from 1b6e5a2 to 6d78f43 Compare February 6, 2025 20:56
@github-actions github-actions bot added the integrations Involves tracing integrations label Feb 6, 2025

Verified

This commit was signed with the committer’s verified signature.
Strech Sergey Fedorov

Verified

This commit was signed with the committer’s verified signature.
Strech Sergey Fedorov

Verified

This commit was signed with the committer’s verified signature.
Strech Sergey Fedorov

Verified

This commit was signed with the committer’s verified signature.
Strech Sergey Fedorov
* Add devise mock user support class

Verified

This commit was signed with the committer’s verified signature.
Strech Sergey Fedorov
@Strech Strech force-pushed the appsec-56683-update-auto-user-instrumentation-mode-configuration branch from 6d78f43 to 000b225 Compare February 10, 2025 13:25

Verified

This commit was signed with the committer’s verified signature.
Strech Sergey Fedorov
@Strech Strech force-pushed the appsec-56683-update-auto-user-instrumentation-mode-configuration branch from 000b225 to cb0e9ad Compare February 10, 2025 13:53
@Strech Strech marked this pull request as ready for review February 10, 2025 13:58
@Strech Strech requested a review from a team as a code owner February 10, 2025 13:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ion-mode-configuration
@Strech Strech enabled auto-merge February 11, 2025 09:58
@Strech Strech merged commit 74cd014 into master Feb 11, 2025
491 of 492 checks passed
@Strech Strech deleted the appsec-56683-update-auto-user-instrumentation-mode-configuration branch February 11, 2025 10:24
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants