Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: Report multiple query errors #4177

Merged
merged 5 commits into from
Feb 14, 2025
Merged

GraphQL: Report multiple query errors #4177

merged 5 commits into from
Feb 14, 2025

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 30, 2024

Captures GraphQL error information as span events:
Screenshot 2025-01-17 at 3 59 23 PM

This is necessary because each query can have multiple errors (GraphQL spec for the "errors" field), which cannot reported using span tags (span tags only support one error per span).

Change log entry
GraphQL query errors are now reported as Span Events. This includes support for multiple errors, if present.

How to test the change?
All changes have unit tests and system-tests: DataDog/system-tests#3840

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 30, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 30, 2024

Datadog Report

Branch report: graphql-error-event
Commit report: a5b863e
Test service: dd-trace-rb

✅ 0 Failed, 22066 Passed, 1476 Skipped, 5m 30.76s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.68%. Comparing base (4e27ecd) to head (91a93c6).

Files with missing lines Patch % Lines
...cing/contrib/graphql/support/application_schema.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4177      +/-   ##
==========================================
- Coverage   97.69%   97.68%   -0.02%     
==========================================
  Files        1352     1352              
  Lines       82735    82785      +50     
  Branches     4200     4204       +4     
==========================================
+ Hits        80829    80869      +40     
- Misses       1906     1916      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Nov 30, 2024

Benchmarks

Benchmark execution time: 2025-02-14 00:41:44

Comparing candidate commit 91a93c6 in PR branch graphql-error-event with baseline commit 4e27ecd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@marcotc marcotc force-pushed the graphql-error-event branch from af565a0 to 10f8fe3 Compare January 17, 2025 23:32
@github-actions github-actions bot added the core Involves Datadog core libraries label Jan 17, 2025
@marcotc marcotc force-pushed the graphql-error-event branch from 10f8fe3 to 523aa51 Compare January 17, 2025 23:54
Copy link

github-actions bot commented Jan 17, 2025

👋 Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-18 00:02:08 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 23, 2025

Datadog Report

Branch report: graphql-error-event
Commit report: 91a93c6
Test service: dd-trace-rb

✅ 0 Failed, 20107 Passed, 1360 Skipped, 3m 19.65s Total Time

@marcotc marcotc force-pushed the graphql-error-event branch from 3b8bf6c to cf6efdc Compare January 27, 2025 23:43
@marcotc marcotc marked this pull request as ready for review January 28, 2025 22:29
@marcotc marcotc requested review from a team as code owners January 28, 2025 22:29
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving docs change. Thanks!

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Looks pretty slick!

@marcotc marcotc merged commit aa7e0da into master Feb 14, 2025
488 checks passed
@marcotc marcotc deleted the graphql-error-event branch February 14, 2025 19:06
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants