Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value from peer.service tag #3846

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Aug 14, 2024

Today, the default value of the span tag peer.service does not provide the correct semantics to populated the new Inferred Service dependency experience.

The peer.service tag should only be used as an explicit user override, which is supported today by APM Ruby.

This PR removes the default value of peer.service, while keeping any explicitly values set by configuration (e.g. c.tracing.instrument :pg, peer_service: 'mydb').

If you need to keep the default values of peer.service, you can set the environment variable DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED=true to restore the behavior to before this change.

Change log entry
Yes. Remove peer services by default, to ensure compatibility with Inferred services, allowing for automatic discovery of instrumented dependencies such as databases, queues, or third-party APIs.
If you need the previous peer service behavior back, set the environment variable DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED=true.

@marcotc marcotc self-assigned this Aug 14, 2024
@marcotc marcotc requested review from a team as code owners August 14, 2024 22:29
@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Aug 14, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024

Benchmarks

Benchmark execution time: 2025-02-14 23:20:53

Comparing candidate commit 6519bea in PR branch DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED with baseline commit 92e97fa in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@marcotc marcotc force-pushed the DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED branch from 1209861 to ccffd07 Compare August 14, 2024 22:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (92e97fa) to head (6519bea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3846   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files        1355     1355           
  Lines       83051    83100   +49     
  Branches     4218     4219    +1     
=======================================
+ Hits        81144    81194   +50     
+ Misses       1907     1906    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivoanjo
Copy link
Member

ivoanjo commented Dec 9, 2024

Hey folks, is this still a thing we want to push forward?

@tatsuo48
Copy link

Hi. I'm using Inferred Service dependency experience in Ruby
So I hope to merge&release this PR.
Thank you!

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 13, 2025

Datadog Report

Branch report: DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED
Commit report: 6519bea
Test service: dd-trace-rb

✅ 0 Failed, 20591 Passed, 1371 Skipped, 3m 12.92s Total Time

@marcotc marcotc enabled auto-merge (squash) February 14, 2025 23:02
@marcotc marcotc merged commit 932b412 into master Feb 14, 2025
487 checks passed
@marcotc marcotc deleted the DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED branch February 14, 2025 23:31
@github-actions github-actions bot added this to the 2.11.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants