-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default value from peer.service
tag
#3846
Conversation
BenchmarksBenchmark execution time: 2025-02-14 23:20:53 Comparing candidate commit 6519bea in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
1209861
to
ccffd07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3846 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 1355 1355
Lines 83051 83100 +49
Branches 4218 4219 +1
=======================================
+ Hits 81144 81194 +50
+ Misses 1907 1906 -1 ☔ View full report in Codecov by Sentry. |
Hey folks, is this still a thing we want to push forward? |
Hi. I'm using Inferred Service dependency experience in Ruby |
Datadog ReportBranch report: ✅ 0 Failed, 20591 Passed, 1371 Skipped, 3m 12.92s Total Time |
Today, the default value of the span tag
peer.service
does not provide the correct semantics to populated the new Inferred Service dependency experience.The
peer.service
tag should only be used as an explicit user override, which is supported today by APM Ruby.This PR removes the default value of
peer.service
, while keeping any explicitly values set by configuration (e.g.c.tracing.instrument :pg, peer_service: 'mydb'
).If you need to keep the default values of
peer.service
, you can set the environment variableDD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED=true
to restore the behavior to before this change.Change log entry
Yes. Remove peer services by default, to ensure compatibility with Inferred services, allowing for automatic discovery of instrumented dependencies such as databases, queues, or third-party APIs.
If you need the previous peer service behavior back, set the environment variable
DD_TRACE_PEER_SERVICE_DEFAULTS_ENABLED=true
.