Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: parametrized framework tests #9315

Merged
merged 14 commits into from
May 21, 2024
Merged

ci: parametrized framework tests #9315

merged 14 commits into from
May 21, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented May 20, 2024

CI: parametrize framework tests to run them separately with Profiling, IAST or Appsec enabled

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: gnufede/framework-tests-matrix
Commit report: 58b6916
Test service: dd-trace-py

❌ 1 Failed (0 Known Flaky), 120743 Passed, 53499 Skipped, 4h 43m 59.89s Total duration (2h 41m 14.7s time saved)

❌ Failed Tests (1)

  • test_auto - test_auto.py - Details

    Expand for error
     Expected status 0, got 1.
     === Captured STDOUT ===
     === End of captured STDOUT ===
     === Captured STDERR ===
     Traceback (most recent call last):
       File "tests/internal/test_auto.py", line 15, in <module>
         assert "threading" not in sys.modules
     AssertionError
     === End of captured STDERR ===
    

@pr-commenter
Copy link

pr-commenter bot commented May 20, 2024

Benchmarks

Benchmark execution time: 2024-05-21 15:28:01

Comparing candidate commit 87aecd5 in PR branch gnufede/framework-tests-matrix with baseline commit d8c21b0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels May 20, 2024
@gnufede gnufede marked this pull request as ready for review May 20, 2024 10:09
@gnufede gnufede requested a review from a team as a code owner May 20, 2024 10:09
@gnufede gnufede requested a review from erikayasuda May 20, 2024 10:09
@gnufede gnufede requested a review from P403n1x87 May 20, 2024 13:33
Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocker, otherwise LGTM

.github/workflows/test_frameworks.yml Show resolved Hide resolved
@gnufede gnufede enabled auto-merge (squash) May 21, 2024 14:53
@gnufede gnufede merged commit 719c561 into main May 21, 2024
50 checks passed
@gnufede gnufede deleted the gnufede/framework-tests-matrix branch May 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants