-
Notifications
You must be signed in to change notification settings - Fork 476
feat(lib-injection): enable 3.14 SSI support #15966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e2b4e11 to
f6ab624
Compare
Codeowners resolved as |
Performance SLOsComparing candidate APMLP-832/ssi.inject.3.14 (957ec9e) with baseline main (1aac0cd) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.558µs (SLO: <130.000µs 📉 -20.3%) vs baseline: +3.0% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.2% ✅ add_inplace_aspectTime: ✅ 101.246µs (SLO: <130.000µs 📉 -22.1%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 28.179µs (SLO: <40.000µs 📉 -29.6%) vs baseline: +0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 48.808µs (SLO: <70.000µs 📉 -30.3%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.4% ✅ bytearray_aspectTime: ✅ 257.845µs (SLO: <400.000µs 📉 -35.5%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytearray_extend_aspectTime: ✅ 652.864µs (SLO: <800.000µs 📉 -18.4%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 268.497µs (SLO: <400.000µs 📉 -32.9%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 141.276µs (SLO: <300.000µs 📉 -52.9%) vs baseline: +1.4% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ bytes_aspectTime: ✅ 222.145µs (SLO: <300.000µs 📉 -26.0%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 133.561µs (SLO: <200.000µs 📉 -33.2%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 3.846ms (SLO: <5.000ms 📉 -23.1%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 320.304µs (SLO: <420.000µs 📉 -23.7%) vs baseline: -0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 89.804µs (SLO: <300.000µs 📉 -70.1%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 252.671µs (SLO: <300.000µs 📉 -15.8%) vs baseline: +1.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 89.624µs (SLO: <500.000µs 📉 -82.1%) vs baseline: -0.6% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ casefold_noaspectTime: ✅ 306.277µs (SLO: <500.000µs 📉 -38.7%) vs baseline: -1.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 87.584µs (SLO: <100.000µs 📉 -12.4%) vs baseline: +0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 153.550µs (SLO: <210.000µs 📉 -26.9%) vs baseline: +0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 85.145µs (SLO: <200.000µs 📉 -57.4%) vs baseline: +0.1% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 139.312µs (SLO: <200.000µs 📉 -30.3%) vs baseline: +1.0% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 14.731ms (SLO: <19.200ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 42.880MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 16.428ms (SLO: <21.500ms 📉 -23.6%) vs baseline: -0.1% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.5% ✅ format_map_noaspectTime: ✅ 373.058µs (SLO: <500.000µs 📉 -25.4%) vs baseline: +1.5% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 308.269µs (SLO: <500.000µs 📉 -38.3%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 133.791µs (SLO: <300.000µs 📉 -55.4%) vs baseline: +8.7% Memory: ✅ 42.703MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.540µs (SLO: <300.000µs 📉 -86.5%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 218.830µs (SLO: <300.000µs 📉 -27.1%) vs baseline: +0.9% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 149.606µs (SLO: <300.000µs 📉 -50.1%) vs baseline: +0.5% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 576.353µs (SLO: <700.000µs 📉 -17.7%) vs baseline: 📈 +15.5% Memory: ✅ 42.743MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +5.1% ✅ ljust_noaspectTime: ✅ 254.626µs (SLO: <300.000µs 📉 -15.1%) vs baseline: -1.3% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ lower_aspectTime: ✅ 304.673µs (SLO: <500.000µs 📉 -39.1%) vs baseline: +0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 233.515µs (SLO: <300.000µs 📉 -22.2%) vs baseline: -1.0% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 0.271ms (SLO: <3.000ms 📉 -91.0%) vs baseline: -1.2% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.179ms (SLO: <3.000ms 📉 -94.0%) vs baseline: +0.8% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 14.393ms (SLO: <18.750ms 📉 -23.2%) vs baseline: ~same Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.847ms (SLO: <19.350ms 📉 -23.3%) vs baseline: -0.3% Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 14.555ms (SLO: <18.900ms 📉 -23.0%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.633ms (SLO: <19.150ms 📉 -23.6%) vs baseline: -0.2% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.361ms (SLO: <3.000ms 📉 -88.0%) vs baseline: +0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ replace_aspectTime: ✅ 18.493ms (SLO: <24.000ms 📉 -22.9%) vs baseline: +0.4% Memory: ✅ 42.900MB (SLO: <44.000MB -2.5%) vs baseline: +5.3% ✅ replace_noaspectTime: ✅ 285.820µs (SLO: <300.000µs -4.7%) vs baseline: -0.7% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 318.922µs (SLO: <420.000µs 📉 -24.1%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 46.971µs (SLO: <90.000µs 📉 -47.8%) vs baseline: +0.9% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 378.407µs (SLO: <500.000µs 📉 -24.3%) vs baseline: -0.7% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 181.682µs (SLO: <300.000µs 📉 -39.4%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 182.790µs (SLO: <300.000µs 📉 -39.1%) vs baseline: +0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 53.844µs (SLO: <90.000µs 📉 -40.2%) vs baseline: -0.8% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 4.458ms (SLO: <5.000ms 📉 -10.8%) vs baseline: 📈 +14.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 355.862µs (SLO: <500.000µs 📉 -28.8%) vs baseline: +0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 269.624µs (SLO: <350.000µs 📉 -23.0%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ strip_noaspectTime: ✅ 178.171µs (SLO: <240.000µs 📉 -25.8%) vs baseline: -1.0% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 344.539µs (SLO: <500.000µs 📉 -31.1%) vs baseline: +0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 269.471µs (SLO: <400.000µs 📉 -32.6%) vs baseline: -0.7% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 332.853µs (SLO: <500.000µs 📉 -33.4%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <43.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 262.220µs (SLO: <400.000µs 📉 -34.4%) vs baseline: +1.1% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ translate_aspectTime: ✅ 501.238µs (SLO: <700.000µs 📉 -28.4%) vs baseline: +0.7% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 424.254µs (SLO: <500.000µs 📉 -15.1%) vs baseline: -1.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 304.801µs (SLO: <500.000µs 📉 -39.0%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 234.940µs (SLO: <400.000µs 📉 -41.3%) vs baseline: +0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 503.442µs (SLO: <700.000µs 📉 -28.1%) vs baseline: 📈 +20.1% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 426.689µs (SLO: <700.000µs 📉 -39.0%) vs baseline: +0.2% Memory: ✅ 42.212MB (SLO: <43.500MB -3.0%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 622.389µs (SLO: <700.000µs 📉 -11.1%) vs baseline: -0.5% Memory: ✅ 42.369MB (SLO: <43.500MB -2.6%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 629.663µs (SLO: <700.000µs 📉 -10.0%) vs baseline: -0.4% Memory: ✅ 42.349MB (SLO: <43.500MB -2.6%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 351.794µs (SLO: <700.000µs 📉 -49.7%) vs baseline: +0.4% Memory: ✅ 42.408MB (SLO: <43.500MB -2.5%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 354.928µs (SLO: <700.000µs 📉 -49.3%) vs baseline: -0.7% Memory: ✅ 42.408MB (SLO: <43.500MB -2.5%) vs baseline: +4.4% ✅ ospathsplit_aspectTime: ✅ 487.353µs (SLO: <700.000µs 📉 -30.4%) vs baseline: -1.1% Memory: ✅ 42.271MB (SLO: <43.500MB -2.8%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 496.979µs (SLO: <700.000µs 📉 -29.0%) vs baseline: -0.9% Memory: ✅ 42.389MB (SLO: <43.500MB -2.6%) vs baseline: +5.2% ✅ ospathsplitdrive_aspectTime: ✅ 372.485µs (SLO: <700.000µs 📉 -46.8%) vs baseline: +0.3% Memory: ✅ 42.349MB (SLO: <43.500MB -2.6%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 73.069µs (SLO: <700.000µs 📉 -89.6%) vs baseline: -0.7% Memory: ✅ 42.271MB (SLO: <43.500MB -2.8%) vs baseline: +4.4% ✅ ospathsplitext_aspectTime: ✅ 458.156µs (SLO: <700.000µs 📉 -34.5%) vs baseline: +0.1% Memory: ✅ 42.369MB (SLO: <43.500MB -2.6%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 460.601µs (SLO: <700.000µs 📉 -34.2%) vs baseline: -0.9% Memory: ✅ 42.389MB (SLO: <43.500MB -2.6%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.415µs (SLO: <20.000µs 📉 -82.9%) vs baseline: 📈 +14.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 199.383µs (SLO: <220.000µs -9.4%) vs baseline: ~same Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.327µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.6% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.343µs (SLO: <230.000µs -7.2%) vs baseline: -0.2% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ 1-gauge-metric-1-timesTime: ✅ 2.180µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.986µs (SLO: <150.000µs -8.7%) vs baseline: +0.4% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.3% ✅ 1-rate-metric-1-timesTime: ✅ 3.166µs (SLO: <20.000µs 📉 -84.2%) vs baseline: -0.1% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 212.676µs (SLO: <250.000µs 📉 -14.9%) vs baseline: -0.3% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 19.901ms (SLO: <22.000ms -9.5%) vs baseline: -0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.218ms (SLO: <2.550ms 📉 -13.0%) vs baseline: ~same Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.417ms (SLO: <1.550ms -8.6%) vs baseline: +0.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.177ms (SLO: <2.550ms 📉 -14.6%) vs baseline: +0.4% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.547µs (SLO: <20.000µs 📉 -77.3%) vs baseline: -0.7% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.640µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.6% Memory: ✅ 35.252MB (SLO: <35.500MB 🟡 -0.7%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.189ms (SLO: <2.500ms 📉 -12.4%) vs baseline: +0.1% Memory: ✅ 36.156MB (SLO: <36.500MB 🟡 -0.9%) vs baseline: +5.0% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Enable injecting into Python 3.14 processes with SSI.
Testing
Risks
Additional Notes