-
Notifications
You must be signed in to change notification settings - Fork 480
Revert "perf(debugger): reduce code origin startup time (#15272)" #15776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c3da4f6.
Performance SLOsComparing candidate revert-15272-code-origin-lazy-wrapping (7811451) with baseline main (7c7d690) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.891µs (SLO: <20.000µs 📉 -10.5%) vs baseline: 📈 +19.8% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 14.930µs (SLO: <20.000µs 📉 -25.4%) vs baseline: -0.3% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.339µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.546µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.7% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 18.095µs (SLO: <30.000µs 📉 -39.7%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 23.980µs (SLO: <30.000µs 📉 -20.1%) vs baseline: +0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 2.727µs (SLO: <10.000µs 📉 -72.7%) vs baseline: -1.6% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ bytearray_noaspectTime: ✅ 1.466µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.3% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 16.747µs (SLO: <20.000µs 📉 -16.3%) vs baseline: +0.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 1.414µs (SLO: <10.000µs 📉 -85.9%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 55.549µs (SLO: <70.000µs 📉 -20.6%) vs baseline: -0.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 3.275µs (SLO: <10.000µs 📉 -67.2%) vs baseline: +0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.2% ✅ capitalize_aspectTime: ✅ 14.723µs (SLO: <20.000µs 📉 -26.4%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 2.587µs (SLO: <10.000µs 📉 -74.1%) vs baseline: +0.6% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 14.686µs (SLO: <20.000µs 📉 -26.6%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 3.146µs (SLO: <10.000µs 📉 -68.5%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 15.592µs (SLO: <30.000µs 📉 -48.0%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.586µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.4% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 14.834µs (SLO: <30.000µs 📉 -50.6%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.495µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +1.0% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 175.436µs (SLO: <200.000µs 📉 -12.3%) vs baseline: +2.5% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 191.104µs (SLO: <200.000µs -4.4%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 3.790µs (SLO: <10.000µs 📉 -62.1%) vs baseline: -1.5% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 3.140µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -0.2% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ index_aspectTime: ✅ 15.379µs (SLO: <20.000µs 📉 -23.1%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 17.149µs (SLO: <20.000µs 📉 -14.3%) vs baseline: +0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 1.561µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.2% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 20.730µs (SLO: <30.000µs 📉 -30.9%) vs baseline: -0.8% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 2.722µs (SLO: <10.000µs 📉 -72.8%) vs baseline: -0.4% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 17.928µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 2.427µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +0.2% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 17.612µs (SLO: <30.000µs 📉 -41.3%) vs baseline: -0.7% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 2.100µs (SLO: <10.000µs 📉 -79.0%) vs baseline: 📈 +13.0% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 166.511µs (SLO: <200.000µs 📉 -16.7%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.534µs (SLO: <200.000µs 📉 -12.7%) vs baseline: +0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 168.520µs (SLO: <200.000µs 📉 -15.7%) vs baseline: -0.1% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.775µs (SLO: <200.000µs 📉 -13.6%) vs baseline: +0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 3.702µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +1.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 212.500µs (SLO: <300.000µs 📉 -29.2%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <44.000MB -3.1%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 2.902µs (SLO: <10.000µs 📉 -71.0%) vs baseline: +0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 1.476µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +4.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.524µs (SLO: <10.000µs 📉 -94.8%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 19.003µs (SLO: <30.000µs 📉 -36.7%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 1.928µs (SLO: <10.000µs 📉 -80.7%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 15.924µs (SLO: <20.000µs 📉 -20.4%) vs baseline: -0.5% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 54.339µs (SLO: <80.000µs 📉 -32.1%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 3.615µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -1.0% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 17.656µs (SLO: <20.000µs 📉 -11.7%) vs baseline: -0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 1.866µs (SLO: <10.000µs 📉 -81.3%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 18.398µs (SLO: <30.000µs 📉 -38.7%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.798µs (SLO: <10.000µs 📉 -72.0%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 18.184µs (SLO: <30.000µs 📉 -39.4%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <43.000MB 🟡 -1.1%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 2.668µs (SLO: <10.000µs 📉 -73.3%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 20.466µs (SLO: <30.000µs 📉 -31.8%) vs baseline: -0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.310µs (SLO: <10.000µs 📉 -56.9%) vs baseline: -0.2% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 17.885µs (SLO: <30.000µs 📉 -40.4%) vs baseline: -1.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 2.427µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.168µs (SLO: <10.000µs 📉 -48.3%) vs baseline: 📈 +21.5% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 4.278µs (SLO: <10.000µs 📉 -57.2%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.256µs (SLO: <10.000µs 📉 -37.4%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 6.316µs (SLO: <10.000µs 📉 -36.8%) vs baseline: -0.2% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.552µs (SLO: <10.000µs 📉 -64.5%) vs baseline: -0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 3.633µs (SLO: <10.000µs 📉 -63.7%) vs baseline: +0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ ospathsplit_aspectTime: ✅ 4.933µs (SLO: <10.000µs 📉 -50.7%) vs baseline: +0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 5.013µs (SLO: <10.000µs 📉 -49.9%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.750µs (SLO: <10.000µs 📉 -62.5%) vs baseline: -0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -1.8% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.628µs (SLO: <10.000µs 📉 -53.7%) vs baseline: +0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 4.651µs (SLO: <10.000µs 📉 -53.5%) vs baseline: -0.7% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.394µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +15.7% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 199.127µs (SLO: <220.000µs -9.5%) vs baseline: +0.1% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.331µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +0.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.729µs (SLO: <230.000µs -6.6%) vs baseline: +0.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.201µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.7% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.869µs (SLO: <150.000µs -8.1%) vs baseline: +1.7% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.4% ✅ 1-rate-metric-1-timesTime: ✅ 3.148µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +0.7% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 215.658µs (SLO: <250.000µs 📉 -13.7%) vs baseline: +1.6% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 20.212ms (SLO: <22.000ms -8.1%) vs baseline: +1.5% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.226ms (SLO: <2.550ms 📉 -12.7%) vs baseline: +0.4% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.422ms (SLO: <1.550ms -8.3%) vs baseline: +1.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +3.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.193ms (SLO: <2.550ms 📉 -14.0%) vs baseline: +0.6% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +3.7% ✅ flush-1-metricTime: ✅ 4.541µs (SLO: <20.000µs 📉 -77.3%) vs baseline: -2.4% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 173.767µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.6% Memory: ✅ 35.389MB (SLO: <35.500MB 🟡 -0.3%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.190ms (SLO: <2.500ms 📉 -12.4%) vs baseline: +0.7% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +5.0% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Codeowners resolved as |
…" (DataDog#15776) This reverts commit DataDog#15272 We detected errors " Context already registered" that we believe related to PR DataDog#15272. So we undo this change and backport the fix.
This reverts commit #15272
We detected errors " Context already registered" that we believe related to PR #15272.
So we undo this change and backport the fix.